chrome/browser/devtools/browser_list_tabcontents_provider.cc - Issue 815983002: Topsites become keyedService based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc

diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc

index b69e4c32446c5cc3c5879423a695b667b1660d09..47001b55b440d1064fe731da806f4d194132cc2a 100644

--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc

+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc

@@ -6,6 +6,7 @@

#include "base/path_service.h"

#include "chrome/browser/history/top_sites.h"

+#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_iterator.h"

@@ -28,7 +29,7 @@ std::string BrowserListTabContentsProvider::GetDiscoveryPageHTML() {

for (std::set<Profile*>::iterator it = profiles.begin();

it != profiles.end(); ++it) {

- history::TopSites* ts = (*it)->GetTopSites();

+ scoped_refptr<history::TopSites> ts = TopSitesFactory::GetForProfile(*it);

if (ts) {

// TopSites updates itself after a delay. Ask TopSites to update itself

// when we're about to show the remote debugging landing page.