Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/history/top_sites_impl.h

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and fixed unit test fail Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/history/top_sites_factory.cc ('K') | « chrome/browser/history/top_sites_factory.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | chrome/browser/ui/browser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/top_sites_impl.h
diff --git a/chrome/browser/history/top_sites_impl.h b/chrome/browser/history/top_sites_impl.h
index cea6f84d8ab24aff6df8483b7a7a4ccfcdb4b0c0..81fd263ebcb715ae25c3e5880dfdbeaf3bc515c3 100644
--- a/chrome/browser/history/top_sites_impl.h
+++ b/chrome/browser/history/top_sites_impl.h
@@ -73,7 +73,6 @@ class TopSitesImpl : public TopSites {
void RemoveBlacklistedURL(const GURL& url) override;
bool IsBlacklisted(const GURL& url) override;
void ClearBlacklistedURLs() override;
- void Shutdown() override;
base::CancelableTaskTracker::TaskId StartQueryForMostVisited() override;
bool IsKnownURL(const GURL& url) override;
const std::string& GetCanonicalURLString(const GURL& url) const override;
@@ -83,6 +82,9 @@ class TopSitesImpl : public TopSites {
bool loaded() const override;
bool AddForcedURL(const GURL& url, const base::Time& time) override;
+ // RefcountedKeyedService:
+ void ShutdownOnUIThread() override;
+
protected:
~TopSitesImpl() override;
« chrome/browser/history/top_sites_factory.cc ('K') | « chrome/browser/history/top_sites_factory.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | chrome/browser/ui/browser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698