Chromium Code Reviews| Index: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc |
| diff --git a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc |
| index e79c849545dc041a4e087d02a95333308b5ec91c..2693794636770880fc32923ff375a9795c222c32 100644 |
| --- a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc |
| +++ b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc |
| @@ -11,6 +11,7 @@ |
| #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" |
| #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h" |
| #include "chrome/browser/history/top_sites.h" |
| +#include "chrome/browser/history/top_sites_factory.h" |
| #include "chrome/browser/search_engines/template_url_service_factory.h" |
| #include "chrome/common/pref_names.h" |
| #include "chrome/test/base/testing_profile.h" |
| @@ -109,6 +110,12 @@ void FakeEmptyTopSites::GetMostVisitedURLs( |
| mv_callback = callback; |
| } |
| +scoped_refptr<RefcountedKeyedService> BuildFakeEmptyTopSites( |
| + content::BrowserContext* profile) { |
| + scoped_refptr<history::TopSites> top_sites = new FakeEmptyTopSites(); |
| + return top_sites; |
| +} |
| + |
| } // namespace |
| @@ -175,8 +182,8 @@ void ZeroSuggestProviderTest::SetUp() { |
| turl_model->Add(default_t_url_); |
| turl_model->SetUserSelectedDefaultSearchProvider(default_t_url_); |
| - profile_.SetTopSites(new FakeEmptyTopSites()); |
| - |
| + TopSitesFactory::GetInstance()->SetTestingFactory(profile_, |
|
sdefresne
2015/01/21 17:57:23
You need to use "&profile_" here and below since "
|
| + BuildFakeEmptyTopSites); |
| provider_ = ZeroSuggestProvider::Create(this, turl_model, &profile_); |
| } |
| @@ -264,8 +271,9 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedCallback) { |
| provider_->Start(input, false, true); |
| EXPECT_TRUE(provider_->matches().empty()); |
| - static_cast<FakeEmptyTopSites*>(profile_.GetTopSites())->mv_callback.Run( |
| - urls); |
| + scoped_refptr<history::TopSites> top_sites = |
| + TopSitesFactory::GetForProfile(profile_); |
| + static_cast<FakeEmptyTopSites*>(top_sites.get())->mv_callback.Run(urls); |
| // Should have verbatim match + most visited url match. |
| EXPECT_EQ(2U, provider_->matches().size()); |
| provider_->Stop(false); |
| @@ -275,8 +283,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedCallback) { |
| EXPECT_TRUE(provider_->matches().empty()); |
| // Most visited results arriving after Stop() has been called, ensure they |
| // are not displayed. |
| - static_cast<FakeEmptyTopSites*>(profile_.GetTopSites())->mv_callback.Run( |
| - urls); |
| + static_cast<FakeEmptyTopSites*>(top_sites.get())->mv_callback.Run(urls); |
| EXPECT_TRUE(provider_->matches().empty()); |
| } |
| @@ -316,8 +323,9 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) { |
| provider_->Start(srp_input, false, true); |
| EXPECT_TRUE(provider_->matches().empty()); |
| // Most visited results arriving after a new request has been started. |
| - static_cast<FakeEmptyTopSites*>(profile_.GetTopSites())->mv_callback.Run( |
| - urls); |
| + scoped_refptr<history::TopSites> top_sites = |
| + TopSitesFactory::GetForProfile(profile_); |
| + static_cast<FakeEmptyTopSites*>(top_sites.get())->mv_callback.Run(urls); |
| EXPECT_TRUE(provider_->matches().empty()); |
| } |