chrome/browser/ui/tabs/tab_strip_model_utils.h - Issue 815983002: Topsites become keyedService based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_utils.h

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the Review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model_utils.h

diff --git a/chrome/browser/ui/tabs/tab_strip_model_utils.h b/chrome/browser/ui/tabs/tab_strip_model_utils.h

index a21ea4d8260712302f336b76da5e0cb62f107f35..c8cbe2a9ebc6dfdc76ce392564c3f3566916120e 100644

--- a/chrome/browser/ui/tabs/tab_strip_model_utils.h

+++ b/chrome/browser/ui/tabs/tab_strip_model_utils.h

@@ -18,7 +18,7 @@ namespace chrome {

// Creates a set containing the canonical URLs of the currently open tabs.

void GetOpenUrls(const TabStripModel& tabs,

- const history::TopSites& top_sites,

+ history::TopSites& top_sites,

Bernhard Bauer 2015/01/12 14:32:23 This should be a const reference. The version on t

Jitu( very slow this week) 2015/01/12 14:55:15 Done.

std::set<std::string>* urls);

} // namespace chrome