chrome/chrome_browser.gypi - Issue 815983002: Topsites become keyedService based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 7d8ffa641eaa4482fc973d12c814334790c819f3..4c932f47f7a37e51b611bb59682a5b23d93c49d5 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1531,16 +1531,18 @@

'browser/history/shortcuts_database.h',

'browser/history/thumbnail_database.cc',

'browser/history/thumbnail_database.h',

- 'browser/history/top_sites.cc',

- 'browser/history/top_sites.h',

'browser/history/top_sites_backend.cc',

'browser/history/top_sites_backend.h',

'browser/history/top_sites_cache.cc',

'browser/history/top_sites_cache.h',

'browser/history/top_sites_database.cc',

'browser/history/top_sites_database.h',

- 'browser/history/top_sites_impl.cc',

+ 'browser/history/top_sites_factory.h',

Bernhard Bauer 2015/01/08 10:22:05 Keep these sorted alphabetically: c before h.

sdefresne 2015/01/08 10:41:02 Keep file name sorted (.cc before .h).

Jitu( very slow this week) 2015/01/12 11:30:08 Done.

+ 'browser/history/top_sites_factory.cc',

'browser/history/top_sites_impl.h',

+ 'browser/history/top_sites_impl.cc',

+ 'browser/history/top_sites.h',

+ 'browser/history/top_sites.cc',

'browser/history/typed_url_syncable_service.cc',

'browser/history/typed_url_syncable_service.h',

'browser/history/url_index_private_data.cc',