Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3339)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_utils.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/tab_strip_model_utils.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model_utils.cc b/chrome/browser/ui/tabs/tab_strip_model_utils.cc
index d3ef0d32843659590af00fef981f6bd14f77a4fe..f8ee7c2b5992e4d923418941019850a278038559 100644
--- a/chrome/browser/ui/tabs/tab_strip_model_utils.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model_utils.cc
@@ -11,12 +11,12 @@
namespace chrome {
void GetOpenUrls(const TabStripModel& tabs,
- const history::TopSites& top_sites,
+ history::TopSites* top_sites,
Bernhard Bauer 2015/01/08 10:22:05 Why this change? There is no need to pass in a poi
Jitu( very slow this week) 2015/01/12 11:30:08 Done.
std::set<std::string>* urls) {
for (int i = 0; i < tabs.count(); ++i) {
content::WebContents* web_contents = tabs.GetWebContentsAt(i);
if (web_contents)
- urls->insert(top_sites.GetCanonicalURLString(web_contents->GetURL()));
+ urls->insert(top_sites->GetCanonicalURLString(web_contents->GetURL()));
}
}

Powered by Google App Engine
This is Rietveld 408576698