Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8200)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_utils.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/thumbnails/thumbnail_service_unittest.cc ('K') | « chrome/browser/ui/tabs/tab_strip_model_utils.h ('k') | chrome/browser/ui/views/frame/global_menu_bar_x11.h » ('j') | chrome/test/base/testing_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/tab_strip_model_utils.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model_utils.cc b/chrome/browser/ui/tabs/tab_strip_model_utils.cc
index d3ef0d32843659590af00fef981f6bd14f77a4fe..f8ee7c2b5992e4d923418941019850a278038559 100644
--- a/chrome/browser/ui/tabs/tab_strip_model_utils.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model_utils.cc
@@ -11,12 +11,12 @@
namespace chrome {
void GetOpenUrls(const TabStripModel& tabs,
- const history::TopSites& top_sites,
+ history::TopSites* top_sites,
std::set<std::string>* urls) {
for (int i = 0; i < tabs.count(); ++i) {
content::WebContents* web_contents = tabs.GetWebContentsAt(i);
if (web_contents)
- urls->insert(top_sites.GetCanonicalURLString(web_contents->GetURL()));
+ urls->insert(top_sites->GetCanonicalURLString(web_contents->GetURL()));
}
}
« chrome/browser/thumbnails/thumbnail_service_unittest.cc ('K') | « chrome/browser/ui/tabs/tab_strip_model_utils.h ('k') | chrome/browser/ui/views/frame/global_menu_bar_x11.h » ('j') | chrome/test/base/testing_profile.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698