chrome/browser/android/provider/chrome_browser_provider.h - Issue 815983002: Topsites become keyedService based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/provider/chrome_browser_provider.h

diff --git a/chrome/browser/android/provider/chrome_browser_provider.h b/chrome/browser/android/provider/chrome_browser_provider.h

index 29f4993d519cf3d45a652ec399a855845f1d2494..3defb2a37a043a67a1418f9e65246e721cc10449 100644

--- a/chrome/browser/android/provider/chrome_browser_provider.h

+++ b/chrome/browser/android/provider/chrome_browser_provider.h

@@ -206,7 +206,7 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,

// alive.

Profile* profile_;

BookmarkModel* bookmark_model_;

- history::TopSites* top_sites_;

+ scoped_refptr<history::TopSites> top_sites_;

FaviconService* favicon_service_;

scoped_ptr<AndroidHistoryProviderService> service_;