Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1953)

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 24b5935a81292cc50c2469439deb35b2fdef2f98..cc7df1231ea9c99a8624481d36239e13afeb8e1c 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -38,7 +38,9 @@
#include "chrome/browser/download/chrome_download_manager_delegate.h"
#include "chrome/browser/download/download_service.h"
#include "chrome/browser/download/download_service_factory.h"
-#include "chrome/browser/history/top_sites.h"
+#include "chrome/browser/history/top_sites_provider.h"
sdefresne 2014/12/19 15:11:42 Remove those three includes.
Jitu( very slow this week) 2014/12/26 14:04:28 Done. Added for testing the code forgot to remove
+#include "chrome/browser/history/top_sites_service.h"
+#include "chrome/browser/history/top_sites_service_factory.h"
#include "chrome/browser/net/chrome_net_log.h"
#include "chrome/browser/net/net_pref_observer.h"
#include "chrome/browser/net/predictor.h"
@@ -822,8 +824,8 @@ ProfileImpl::~ProfileImpl() {
BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices(
this);
- if (top_sites_.get())
- top_sites_->Shutdown();
+ // if (top_sites_service_.get())
sdefresne 2014/12/19 15:11:42 Dead code, remove.
Jitu( very slow this week) 2014/12/26 14:04:28 Done.
+ // top_sites_service_->Shutdown();
if (pref_proxy_config_tracker_)
pref_proxy_config_tracker_->DetachFromPrefService();
@@ -1167,18 +1169,6 @@ Time ProfileImpl::GetStartTime() const {
return start_time_;
}
-history::TopSites* ProfileImpl::GetTopSites() {
- if (!top_sites_.get()) {
- top_sites_ = history::TopSites::Create(
- this, GetPath().Append(chrome::kTopSitesFilename));
- }
- return top_sites_.get();
-}
-
-history::TopSites* ProfileImpl::GetTopSitesWithoutCreating() {
- return top_sites_.get();
-}
-
#if defined(ENABLE_SESSION_SERVICE)
void ProfileImpl::StopCreateSessionServiceTimer() {
create_session_service_timer_.Stop();

Powered by Google App Engine
This is Rietveld 408576698