Topsites become keyedService based.

chrome/browser/history/top_sites_factory.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_HISTORY_TOP_SITES_FACTORY_H_
+#define CHROME_BROWSER_HISTORY_TOP_SITES_FACTORY_H_
+
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/history/top_sites.h"

[sdefresne, 2015/01/22 19:05:05]

nit: you don't need this #include, instead you can forward-declare TopSites in
the history namespace.

[sdefresne, 2015/01/22 19:05:05]

nit: you don't need this #include, instead you can forward-declare TopSites in
the history namespace.

[Jitu( very slow this week), 2015/01/23 11:36:53]

Done.

+#include "components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h"
+
+template <typename T>
+struct DefaultSingletonTraits;
+
+// Used for creating and fetching a per-profile instance of the
+// TopSites.
+class TopSitesFactory : public RefcountedBrowserContextKeyedServiceFactory {
+ public:
+  // Get the TopSites service for |profile|, creating one if needed.
+  static scoped_refptr<history::TopSites> GetForProfile(Profile* profile);
+
+  // Get the TopSites service for |profile|, but do not create it if it doesn't
+  // exist.
+  static scoped_refptr<history::TopSites> GetForProfileIfExists(
+      Profile* profile);
+
+  // Get the singleton instance of the factory.
+  static TopSitesFactory* GetInstance();
+
+  static void ShutdownForProfile(Profile* profile);

[sdefresne, 2015/01/22 19:05:05]

This is unused, remove.

[Jitu( very slow this week), 2015/01/23 11:36:53]

Done.

+
+ private:
+  // Overridden from BrowserContextKeyedServiceFactory.
+  scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(
+      content::BrowserContext* context) const override;
+

[sdefresne, 2015/01/22 19:05:05]

style: remove empty line

[Jitu( very slow this week), 2015/01/23 11:36:52]

Done.

+  bool ServiceIsNULLWhileTesting() const override;
+
+  friend struct DefaultSingletonTraits<TopSitesFactory>;

[sdefresne, 2015/01/22 19:05:05]

style: friend should go before methods

[Bernhard Bauer, 2015/01/22 21:23:27]

Friend declarations come first in the private section.

[Jitu( very slow this week), 2015/01/23 11:36:52]

Done.

[Jitu( very slow this week), 2015/01/23 11:36:53]

Done.

+
+  TopSitesFactory();
+  ~TopSitesFactory() override;
+
+  DISALLOW_COPY_AND_ASSIGN(TopSitesFactory);
+};
+
+#endif  // CHROME_BROWSER_HISTORY_TOP_SITES_FACTORY_H_