Topsites become keyedService based.

chrome/browser/ui/views/frame/global_menu_bar_x11.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/global_menu_bar_x11.h"
 
 #include <dlfcn.h>
 #include <glib-object.h>
 
 #include "base/debug/leak_annotations.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/history/top_sites.h"
+#include "chrome/browser/history/top_sites_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/sessions/tab_restore_service.h"
 #include "chrome/browser/sessions/tab_restore_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tab_restore_service_delegate.h"
 #include "chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.h"
@@ skipping 388 matching lines @@
     chrome::AddCommandObserver(browser_, it->first, this);
   }
 
   pref_change_registrar_.Init(browser_->profile()->GetPrefs());
   pref_change_registrar_.Add(
       bookmarks::prefs::kShowBookmarkBar,
       base::Bind(&GlobalMenuBarX11::OnBookmarkBarVisibilityChanged,
                  base::Unretained(this)));
   OnBookmarkBarVisibilityChanged();
 
-  top_sites_ = profile_->GetTopSites();
-  if (top_sites_) {
+  top_sites_ = TopSitesFactory::GetForProfile(profile_);
+  if (top_sites_.get()) {

[Bernhard Bauer, 2015/01/08 10:22:05]

Remove .get().

[Jitu( very slow this week), 2015/01/12 11:30:08]

Done.

     GetTopSitesData();
 
     // Register for notification when TopSites changes so that we can update
     // ourself.
     registrar_.Add(this, chrome::NOTIFICATION_TOP_SITES_CHANGED,
-                   content::Source<history::TopSites>(top_sites_));
+                   content::Source<history::TopSites>(top_sites_.get()));
   }
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   DCHECK(profile_manager);
   avatar_menu_.reset(new AvatarMenu(
       &profile_manager->GetProfileInfoCache(), this, nullptr));
   avatar_menu_->RebuildMenu();
   BrowserList::AddObserver(this);
 
   RebuildProfilesMenu();
@@ skipping 113 matching lines @@
   g_signal_connect(menu_item, "item-activated",
                    G_CALLBACK(OnHistoryItemActivatedThunk), this);
 
   g_object_set_data_full(G_OBJECT(menu_item), kHistoryItem, item,
                          DeleteHistoryItem);
   menuitem_child_add_position(menu, menu_item, index);
   g_object_unref(menu_item);
 }
 
 void GlobalMenuBarX11::GetTopSitesData() {
-  DCHECK(top_sites_);
+  DCHECK(top_sites_.get());

[Bernhard Bauer, 2015/01/08 10:22:05]

Remove the .get().

[Jitu( very slow this week), 2015/01/12 11:30:08]

Done.

 
   top_sites_->GetMostVisitedURLs(
       base::Bind(&GlobalMenuBarX11::OnTopSitesReceived,
                  weak_ptr_factory_.GetWeakPtr()), false);
 }
 
 void GlobalMenuBarX11::OnTopSitesReceived(
     const history::MostVisitedURLList& visited_list) {
   ClearMenuSection(history_menu_, TAG_MOST_VISITED);
 
@@ skipping 311 matching lines @@
 void GlobalMenuBarX11::OnEditProfileItemActivated(DbusmenuMenuitem* sender,
                                                   unsigned int timestamp) {
   int id = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(sender), kProfileId));
   avatar_menu_->EditProfile(id);
 }
 
 void GlobalMenuBarX11::OnCreateProfileItemActivated(DbusmenuMenuitem* sender,
                                                     unsigned int timestamp) {
   avatar_menu_->AddNewProfile(ProfileMetrics::ADD_NEW_USER_MENU);
 }