OLD | NEW |
---|---|
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/thumbnails/thumbnail_service_impl.h" | 5 #include "chrome/browser/thumbnails/thumbnail_service_impl.h" |
6 | 6 |
7 #include "base/memory/ref_counted.h" | 7 #include "base/memory/ref_counted.h" |
8 #include "chrome/browser/history/top_sites_impl.h" | 8 #include "chrome/browser/history/top_sites_impl.h" |
9 #include "chrome/browser/history/top_sites_factory.h" | |
9 #include "chrome/test/base/testing_profile.h" | 10 #include "chrome/test/base/testing_profile.h" |
10 #include "testing/gtest/include/gtest/gtest.h" | 11 #include "testing/gtest/include/gtest/gtest.h" |
11 | 12 |
12 typedef testing::Test ThumbnailServiceTest; | 13 typedef testing::Test ThumbnailServiceTest; |
13 | 14 |
15 namespace { | |
16 | |
17 scoped_refptr<RefcountedKeyedService> BuildMockTopSites( | |
18 content::BrowserContext* profile) { | |
19 return scoped_refptr<RefcountedKeyedService>( | |
20 new MockTopSites(static_cast<Profile*>(profile))); | |
21 } | |
22 | |
23 } // namespace | |
24 | |
14 // A mock version of TopSitesImpl, used for testing | 25 // A mock version of TopSitesImpl, used for testing |
15 // ShouldAcquirePageThumbnail(). | 26 // ShouldAcquirePageThumbnail(). |
16 class MockTopSites : public history::TopSitesImpl { | 27 class MockTopSites : public history::TopSitesImpl { |
17 public: | 28 public: |
18 explicit MockTopSites(Profile* profile) | 29 explicit MockTopSites(Profile* profile) |
19 : history::TopSitesImpl(profile), | 30 : history::TopSitesImpl(profile), capacity_(1) {} |
20 capacity_(1) { | |
21 } | |
22 | 31 |
23 // history::TopSitesImpl overrides. | 32 // history::TopSitesImpl overrides. |
24 bool IsNonForcedFull() override { return known_url_map_.size() >= capacity_; } | 33 bool IsNonForcedFull() override { return known_url_map_.size() >= capacity_; } |
25 bool IsForcedFull() override { return false; } | 34 bool IsForcedFull() override { return false; } |
26 bool IsKnownURL(const GURL& url) override { | 35 bool IsKnownURL(const GURL& url) override { |
27 return known_url_map_.find(url.spec()) != known_url_map_.end(); | 36 return known_url_map_.find(url.spec()) != known_url_map_.end(); |
28 } | 37 } |
29 bool GetPageThumbnailScore(const GURL& url, ThumbnailScore* score) override { | 38 bool GetPageThumbnailScore(const GURL& url, ThumbnailScore* score) override { |
30 std::map<std::string, ThumbnailScore>::const_iterator iter = | 39 std::map<std::string, ThumbnailScore>::const_iterator iter = |
31 known_url_map_.find(url.spec()); | 40 known_url_map_.find(url.spec()); |
(...skipping 15 matching lines...) Expand all Loading... | |
47 | 56 |
48 const size_t capacity_; | 57 const size_t capacity_; |
49 std::map<std::string, ThumbnailScore> known_url_map_; | 58 std::map<std::string, ThumbnailScore> known_url_map_; |
50 | 59 |
51 DISALLOW_COPY_AND_ASSIGN(MockTopSites); | 60 DISALLOW_COPY_AND_ASSIGN(MockTopSites); |
52 }; | 61 }; |
53 | 62 |
54 // A mock version of TestingProfile holds MockTopSites. | 63 // A mock version of TestingProfile holds MockTopSites. |
55 class MockProfile : public TestingProfile { | 64 class MockProfile : public TestingProfile { |
56 public: | 65 public: |
57 MockProfile() : mock_top_sites_(new MockTopSites(this)) { | 66 MockProfile() { |
67 TopSitesFactory::GetInstance()::SetTestingFactory(this, BuildMockTopSites); | |
58 } | 68 } |
59 | 69 |
60 history::TopSites* GetTopSites() override { return mock_top_sites_.get(); } | |
61 | |
62 void AddKnownURL(const GURL& url, const ThumbnailScore& score) { | 70 void AddKnownURL(const GURL& url, const ThumbnailScore& score) { |
63 mock_top_sites_->AddKnownURL(url, score); | 71 scoped_refptr<history::TopSites> top_sites = |
72 TopSitesFactory::GetForProfile(this); | |
73 top_sites->AddKnownURL(url, score); | |
sdefresne
2015/01/08 10:41:02
AddKnownURL is not a method of history::TopSites,
Jitu( very slow this week)
2015/01/12 11:30:08
Done.
| |
64 } | 74 } |
65 | 75 |
66 private: | 76 private: |
67 scoped_refptr<MockTopSites> mock_top_sites_; | |
68 | 77 |
69 DISALLOW_COPY_AND_ASSIGN(MockProfile); | 78 DISALLOW_COPY_AND_ASSIGN(MockProfile); |
70 }; | 79 }; |
71 | 80 |
72 TEST_F(ThumbnailServiceTest, ShouldUpdateThumbnail) { | 81 TEST_F(ThumbnailServiceTest, ShouldUpdateThumbnail) { |
73 const GURL kGoodURL("http://www.google.com/"); | 82 const GURL kGoodURL("http://www.google.com/"); |
74 const GURL kBadURL("chrome://newtab"); | 83 const GURL kBadURL("chrome://newtab"); |
75 | 84 |
76 // Set up the mock profile along with mock top sites. | 85 // Set up the mock profile along with mock top sites. |
77 base::ScopedTempDir temp_dir; | 86 base::ScopedTempDir temp_dir; |
78 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); | 87 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); |
79 MockProfile profile; | 88 MockProfile profile; |
80 | 89 |
81 scoped_refptr<thumbnails::ThumbnailService> thumbnail_service( | 90 scoped_refptr<thumbnails::ThumbnailService> thumbnail_service( |
82 new thumbnails::ThumbnailServiceImpl(&profile)); | 91 new thumbnails::ThumbnailServiceImpl(&profile)); |
83 | 92 |
84 // Should be false because it's a bad URL. | 93 // Should be false because it's a bad URL. |
85 EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kBadURL)); | 94 EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kBadURL)); |
86 | 95 |
87 // Should be true, as it's a good URL. | 96 // Should be true, as it's a good URL. |
88 EXPECT_TRUE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL)); | 97 EXPECT_TRUE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL)); |
89 | 98 |
90 // Not checking incognito mode since the service wouldn't have been created | 99 // Not checking incognito mode since the service wouldn't have been created |
91 // in that case anyway. | 100 // in that case anyway. |
92 | 101 |
93 // Add a known URL. This makes the top sites data full. | 102 // Add a known URL. This makes the top sites data full. |
94 ThumbnailScore bad_score; | 103 ThumbnailScore bad_score; |
95 bad_score.time_at_snapshot = base::Time::UnixEpoch(); // Ancient time stamp. | 104 bad_score.time_at_snapshot = base::Time::UnixEpoch(); // Ancient time stamp. |
96 profile.AddKnownURL(kGoodURL, bad_score); | 105 profile.AddKnownURL(kGoodURL, bad_score); |
97 ASSERT_TRUE(profile.GetTopSites()->IsNonForcedFull()); | 106 scoped_refptr<history::TopSites> top_sites = |
107 TopSitesFactory::GetForProfile(profile); | |
108 ASSERT_TRUE(top_sites->IsNonForcedFull()); | |
98 | 109 |
99 // Should be false, as the top sites data is full, and the new URL is | 110 // Should be false, as the top sites data is full, and the new URL is |
100 // not known. | 111 // not known. |
101 const GURL kAnotherGoodURL("http://www.youtube.com/"); | 112 const GURL kAnotherGoodURL("http://www.youtube.com/"); |
102 EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kAnotherGoodURL)); | 113 EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kAnotherGoodURL)); |
103 | 114 |
104 // Should be true, as the existing thumbnail is bad (i.e. need a better one). | 115 // Should be true, as the existing thumbnail is bad (i.e. need a better one). |
105 EXPECT_TRUE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL)); | 116 EXPECT_TRUE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL)); |
106 | 117 |
107 // Replace the thumbnail score with a really good one. | 118 // Replace the thumbnail score with a really good one. |
108 ThumbnailScore good_score; | 119 ThumbnailScore good_score; |
109 good_score.time_at_snapshot = base::Time::Now(); // Very new. | 120 good_score.time_at_snapshot = base::Time::Now(); // Very new. |
110 good_score.at_top = true; | 121 good_score.at_top = true; |
111 good_score.good_clipping = true; | 122 good_score.good_clipping = true; |
112 good_score.boring_score = 0.0; | 123 good_score.boring_score = 0.0; |
113 good_score.load_completed = true; | 124 good_score.load_completed = true; |
114 profile.AddKnownURL(kGoodURL, good_score); | 125 profile.AddKnownURL(kGoodURL, good_score); |
115 | 126 |
116 // Should be false, as the existing thumbnail is good enough (i.e. don't | 127 // Should be false, as the existing thumbnail is good enough (i.e. don't |
117 // need to replace the existing thumbnail which is new and good). | 128 // need to replace the existing thumbnail which is new and good). |
118 EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL)); | 129 EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL)); |
119 } | 130 } |
OLD | NEW |