chrome/browser/history/top_sites_impl.h - Issue 815983002: Topsites become keyedService based.

Side by Side Diff: chrome/browser/history/top_sites_impl.h

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/history/top_sites_factory.cc ('K') | « chrome/browser/history/top_sites_factory.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | chrome/browser/history/top_sites_impl_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_	5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_

6 #define CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_	6 #define CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_

7	7

8 #include <list>	8 #include <list>

9 #include <set>	9 #include <set>

10 #include <string>	10 #include <string>

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75 void ClearBlacklistedURLs() override;	75 void ClearBlacklistedURLs() override;

76 void Shutdown() override;	76 void Shutdown() override;

77 base::CancelableTaskTracker::TaskId StartQueryForMostVisited() override;	77 base::CancelableTaskTracker::TaskId StartQueryForMostVisited() override;

78 bool IsKnownURL(const GURL& url) override;	78 bool IsKnownURL(const GURL& url) override;

79 const std::string& GetCanonicalURLString(const GURL& url) const override;	79 const std::string& GetCanonicalURLString(const GURL& url) const override;

80 bool IsNonForcedFull() override;	80 bool IsNonForcedFull() override;

81 bool IsForcedFull() override;	81 bool IsForcedFull() override;

82 MostVisitedURLList GetPrepopulatePages() override;	82 MostVisitedURLList GetPrepopulatePages() override;

83 bool loaded() const override;	83 bool loaded() const override;

84 bool AddForcedURL(const GURL& url, const base::Time& time) override;	84 bool AddForcedURL(const GURL& url, const base::Time& time) override;

	85 // RefcountedKeyedService:
	sdefresne 2015/01/08 10:41:02 nit: add a blank line before. nit: add a blank line before. Jitu( very slow this week) 2015/01/12 11:30:08 Done. Show quoted text On 2015/01/08 10:41:02, sdefresne wrote: > nit: add a blank line before. Done.
	86 void ShutdownOnUIThread() override;

85	87

86 protected:	88 protected:

87 ~TopSitesImpl() override;	89 ~TopSitesImpl() override;

88	90

89 private:	91 private:

90 friend class TopSitesImplTest;	92 friend class TopSitesImplTest;

91 FRIEND_TEST_ALL_PREFIXES(TopSitesImplTest, DiffMostVisited);	93 FRIEND_TEST_ALL_PREFIXES(TopSitesImplTest, DiffMostVisited);

92 FRIEND_TEST_ALL_PREFIXES(TopSitesImplTest, DiffMostVisitedWithForced);	94 FRIEND_TEST_ALL_PREFIXES(TopSitesImplTest, DiffMostVisitedWithForced);

93	95

94 typedef base::Callback<void(const MostVisitedURLList&,	96 typedef base::Callback<void(const MostVisitedURLList&,

(...skipping 161 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
256	258

257 // Are we loaded?	259 // Are we loaded?

258 bool loaded_;	260 bool loaded_;

259	261

260 DISALLOW_COPY_AND_ASSIGN(TopSitesImpl);	262 DISALLOW_COPY_AND_ASSIGN(TopSitesImpl);

261 };	263 };

262	264

263 } // namespace history	265 } // namespace history

264	266

265 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_	267 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_

OLD	NEW