Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
7 7
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 199
200 JavaObjectWeakGlobalRef weak_java_provider_; 200 JavaObjectWeakGlobalRef weak_java_provider_;
201 201
202 // Profile must outlive this object. 202 // Profile must outlive this object.
203 // 203 //
204 // BookmarkModel, HistoryService and history::TopSites lifetime is bound to 204 // BookmarkModel, HistoryService and history::TopSites lifetime is bound to
205 // the lifetime of Profile, they are safe to use as long as the Profile is 205 // the lifetime of Profile, they are safe to use as long as the Profile is
206 // alive. 206 // alive.
207 Profile* profile_; 207 Profile* profile_;
208 BookmarkModel* bookmark_model_; 208 BookmarkModel* bookmark_model_;
209 history::TopSites* top_sites_; 209 scoped_refptr<history::TopSites> top_sites_;
210 FaviconService* favicon_service_; 210 FaviconService* favicon_service_;
211 211
212 scoped_ptr<AndroidHistoryProviderService> service_; 212 scoped_ptr<AndroidHistoryProviderService> service_;
213 213
214 base::CancelableTaskTracker cancelable_task_tracker_; 214 base::CancelableTaskTracker cancelable_task_tracker_;
215 215
216 // Used to register/unregister notification observer. 216 // Used to register/unregister notification observer.
217 content::NotificationRegistrar notification_registrar_; 217 content::NotificationRegistrar notification_registrar_;
218 ScopedObserver<HistoryService, HistoryServiceObserver> 218 ScopedObserver<HistoryService, HistoryServiceObserver>
219 history_service_observer_; 219 history_service_observer_;
220 220
221 bool handling_extensive_changes_; 221 bool handling_extensive_changes_;
222 222
223 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider); 223 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider);
224 }; 224 };
225 225
226 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 226 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698