Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: chrome/browser/history/chrome_history_client_factory.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/chrome_history_client_factory.h" 5 #include "chrome/browser/history/chrome_history_client_factory.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/history/chrome_history_client.h" 9 #include "chrome/browser/history/chrome_history_client.h"
10 #include "chrome/browser/history/top_sites_service_factory.h"
10 #include "chrome/browser/profiles/incognito_helpers.h" 11 #include "chrome/browser/profiles/incognito_helpers.h"
11 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
12 #include "components/keyed_service/content/browser_context_dependency_manager.h" 13 #include "components/keyed_service/content/browser_context_dependency_manager.h"
13 14
14 // static 15 // static
15 ChromeHistoryClient* ChromeHistoryClientFactory::GetForProfile( 16 ChromeHistoryClient* ChromeHistoryClientFactory::GetForProfile(
16 Profile* profile) { 17 Profile* profile) {
17 return static_cast<ChromeHistoryClient*>( 18 return static_cast<ChromeHistoryClient*>(
18 GetInstance()->GetServiceForBrowserContext(profile, true)); 19 GetInstance()->GetServiceForBrowserContext(profile, true));
19 } 20 }
20 21
21 // static 22 // static
22 ChromeHistoryClient* ChromeHistoryClientFactory::GetForProfileWithoutCreating( 23 ChromeHistoryClient* ChromeHistoryClientFactory::GetForProfileWithoutCreating(
23 Profile* profile) { 24 Profile* profile) {
24 return static_cast<ChromeHistoryClient*>( 25 return static_cast<ChromeHistoryClient*>(
25 GetInstance()->GetServiceForBrowserContext(profile, false)); 26 GetInstance()->GetServiceForBrowserContext(profile, false));
26 } 27 }
27 28
28 // static 29 // static
29 ChromeHistoryClientFactory* ChromeHistoryClientFactory::GetInstance() { 30 ChromeHistoryClientFactory* ChromeHistoryClientFactory::GetInstance() {
30 return Singleton<ChromeHistoryClientFactory>::get(); 31 return Singleton<ChromeHistoryClientFactory>::get();
31 } 32 }
32 33
33 ChromeHistoryClientFactory::ChromeHistoryClientFactory() 34 ChromeHistoryClientFactory::ChromeHistoryClientFactory()
34 : BrowserContextKeyedServiceFactory( 35 : BrowserContextKeyedServiceFactory(
35 "ChromeHistoryClient", 36 "ChromeHistoryClient",
36 BrowserContextDependencyManager::GetInstance()) { 37 BrowserContextDependencyManager::GetInstance()) {
37 DependsOn(BookmarkModelFactory::GetInstance()); 38 DependsOn(BookmarkModelFactory::GetInstance());
sdefresne 2014/12/19 15:11:40 You have to add an explicit dependency on TopSites
Jitu( very slow this week) 2014/12/26 14:04:27 Done.
38 } 39 }
39 40
40 ChromeHistoryClientFactory::~ChromeHistoryClientFactory() { 41 ChromeHistoryClientFactory::~ChromeHistoryClientFactory() {
41 } 42 }
42 43
43 KeyedService* ChromeHistoryClientFactory::BuildServiceInstanceFor( 44 KeyedService* ChromeHistoryClientFactory::BuildServiceInstanceFor(
44 content::BrowserContext* context) const { 45 content::BrowserContext* context) const {
45 Profile* profile = static_cast<Profile*>(context); 46 Profile* profile = static_cast<Profile*>(context);
46 return new ChromeHistoryClient(BookmarkModelFactory::GetForProfile(profile), 47 return new ChromeHistoryClient(
47 profile, 48 BookmarkModelFactory::GetForProfile(profile), profile,
48 profile->GetTopSites()); 49 TopSitesServiceFactory::GetForProfile(profile));
49 } 50 }
50 51
51 content::BrowserContext* ChromeHistoryClientFactory::GetBrowserContextToUse( 52 content::BrowserContext* ChromeHistoryClientFactory::GetBrowserContextToUse(
52 content::BrowserContext* context) const { 53 content::BrowserContext* context) const {
53 return chrome::GetBrowserContextRedirectedInIncognito(context); 54 return chrome::GetBrowserContextRedirectedInIncognito(context);
54 } 55 }
55 56
56 bool ChromeHistoryClientFactory::ServiceIsNULLWhileTesting() const { 57 bool ChromeHistoryClientFactory::ServiceIsNULLWhileTesting() const {
57 return true; 58 return true;
58 } 59 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698