Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 815953002: Vector-based ICs also need to hold maps weakly. (Closed)

Created:
6 years ago by mvstanton
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Vector-based ICs also need to hold maps weakly. Regular ICs in MONOMORPHIC and POLYMORPHIC state now hold onto maps with WeakCells. Vector-based ICs should do the same. R=ulan@chromium.org Committed: https://crrev.com/ad033893d6eda241aba519226f7db49b053841ca Cr-Commit-Position: refs/heads/master@{#25907}

Patch Set 1 #

Patch Set 2 : REBASE and don't perform coalesce step. #

Patch Set 3 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -41 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M src/type-feedback-vector.cc View 1 8 chunks +36 lines, -17 lines 0 comments Download
M test/cctest/test-heap.cc View 1 10 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mvstanton
Hi Ulan, This allows vector-ics to be weakly walked. Note that CALL_IC doesn't change it's ...
6 years ago (2014-12-19 12:51:31 UTC) #1
mvstanton
Hi Ulan, Here is a rebase and fix for the comments. I didn't see your ...
6 years ago (2014-12-19 14:15:04 UTC) #2
ulan
LGTM > I didn't see your change in hydrogen-instructions.h after all? Ah, right, just saw ...
6 years ago (2014-12-19 14:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815953002/40001
6 years ago (2014-12-19 16:27:06 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-19 16:53:47 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-19 16:53:57 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ad033893d6eda241aba519226f7db49b053841ca
Cr-Commit-Position: refs/heads/master@{#25907}

Powered by Google App Engine
This is Rietveld 408576698