Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 815933002: [WebView] Move external video surface across container views. (Closed)

Created:
6 years ago by Ignacio Solla
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, jam, android-webview-reviews_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Target Ref:
refs/pending/branch-heads/2214
Project:
chromium
Visibility:
Public.

Description

[WebView] Move external video surface across container views. When transitioning from/to fullscreen the WebView replaces the container view. We need to move the ExternalVideoSurfaceContainer across container views when this happens. Note that in fullscreen the video may still be embedded in the page if the element in fullscreen is, for example, a <div> containing the <video>. BUG=440774, 398485 TEST=Manual 1. Force use of external surface (set needs_external_surface_ to true in webmediaplayer_android.cc) 2. Load the following url on a test app using a WebView: http://robnyman.github.io/fullscreen/ 3. Test with 2 different actions here: a. Go fullscreen on the <video> element by clicking on the fullscreen video control b. Go fullscreen on the <div> element by clicking on the “Fullscreen” button 4. Notice: video continues in fullscreen without frozen video and in the case of b the video still scrolls with the page Review URL: https://codereview.chromium.org/799953002 Cr-Commit-Position: refs/heads/master@{#309000} (cherry picked from commit 5eba22cd252a34432d26649b06fa4e574fc84528) Committed: https://chromium.googlesource.com/chromium/src/+/46075d31af170affe93e7e3218d7dd6bc3f93b65

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
Ignacio Solla
6 years ago (2014-12-19 11:11:02 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46075d31af170affe93e7e3218d7dd6bc3f93b65.

Powered by Google App Engine
This is Rietveld 408576698