Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5221)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.h

Issue 815863002: Suffixed histograms for SB2.DatabaseKilobytes and SB2.PrefixSetKilobytes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aV_threadSafeStoreManager
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h
index 32d01eb76a25996be6f82e01aebda6f6ae7641e9..a2f085fa5535ce0ce64032518a0539c063627755 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.h
+++ b/chrome/browser/safe_browsing/safe_browsing_database.h
@@ -497,7 +497,7 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
// |write_failure_type| provides a caller-specific error code to be used on
// failure.
void WritePrefixSet(const base::FilePath& db_filename,
- const safe_browsing::PrefixSet* prefix_set,
+ PrefixSetId prefix_set_id,
FailureType write_failure_type);
// Loads the given full-length hashes to the given whitelist. If the number
@@ -562,6 +562,15 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
// synchronization are not problematic).
PrefixGetHashCache* GetUnsynchronizedPrefixGetHashCacheForTesting();
+ // Records |sample| for |histogram_name_base| suffixed by the appropriate
+ // histogram suffix for |(prefix_set_id|whitelist_id)|.
+ void RecordPrefixSetCountsHistogram(const std::string& histogram_name_base,
+ PrefixSetId prefix_set_id,
+ int sample);
+ void RecordSBWhitelistCountsHistogram(const std::string& histogram_name_base,
+ SBWhitelistId whitelist_id,
+ int sample);
+
base::ThreadChecker thread_checker_;
ThreadSafeStateManager state_manager_;

Powered by Google App Engine
This is Rietveld 408576698