Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 815853005: RuleCanUseFastCheckSelector flag unused. (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

RuleCanUseFastCheckSelector flag unused. Removed it. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188242

Patch Set 1 #

Total comments: 2

Patch Set 2 : Useless cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/css/RuleSet.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
rune
5 years, 11 months ago (2015-01-12 14:30:30 UTC) #1
rune
https://codereview.chromium.org/815853005/diff/1/Source/core/css/RuleSet.cpp File Source/core/css/RuleSet.cpp (right): https://codereview.chromium.org/815853005/diff/1/Source/core/css/RuleSet.cpp#newcode298 Source/core/css/RuleSet.cpp:298: addRuleFlags = static_cast<AddRuleFlags>(addRuleFlags); Bleh. Useless cast.
5 years, 11 months ago (2015-01-12 14:44:13 UTC) #2
rune
https://codereview.chromium.org/815853005/diff/1/Source/core/css/RuleSet.cpp File Source/core/css/RuleSet.cpp (right): https://codereview.chromium.org/815853005/diff/1/Source/core/css/RuleSet.cpp#newcode298 Source/core/css/RuleSet.cpp:298: addRuleFlags = static_cast<AddRuleFlags>(addRuleFlags); On 2015/01/12 at 14:44:13, rune wrote: ...
5 years, 11 months ago (2015-01-12 14:47:06 UTC) #3
esprehn
lgtm
5 years, 11 months ago (2015-01-12 18:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815853005/20001
5 years, 11 months ago (2015-01-12 18:37:50 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 20:10:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188242

Powered by Google App Engine
This is Rietveld 408576698