third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 815833005: [css-grid] Handle min-content/max-content with orthogonal flows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 815833005: [css-grid] Handle min-content/max-content with orthogonal flows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch rebased and applied the suggested changes. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 24154469a213ee910a2faf91521f742e44581f37..dff62aec7361f6fa8bca9934fc728122caa2cce1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1125,7 +1125,7 @@ void LayoutBlock::markFixedPositionObjectForLayoutIfNeeded(LayoutObject* child,

}

-LayoutUnit LayoutBlock::marginIntrinsicLogicalWidthForChild(LayoutBox& child) const

+LayoutUnit LayoutBlock::marginIntrinsicLogicalWidthForChild(const LayoutBox& child) const

svillar 2016/04/14 08:58:41 I know I've already said this, but this is not a g

cbiesinger 2016/04/14 16:31:18 Why? This change seems like a good thing regardles

svillar 2016/04/15 12:51:01 As I said privately, the change seems good as the

{

// A margin has three types: fixed, percentage, and auto (variable).

// Auto and percentage margins become 0 when computing min/max width.