Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html

Issue 815833005: [css-grid] Handle min-content/max-content with orthogonal flows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: New approach (Step3) - Assumed row track's breadth for intrinsic size computation. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows-expected.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html
new file mode 100644
index 0000000000000000000000000000000000000000..df0df4ee55577e018bca920624fdb22cc3cc529c
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html
@@ -0,0 +1,75 @@
+<!DOCTYPE html>
+<link href="resources/grid.css" rel="stylesheet">
+<script src="../../resources/check-layout.js"></script>
+<style>
+body {
+ margin: 0;
+}
+
+.container {
+ position: relative;
+}
+
+.grid {
+ font: 10px/1 Ahem;
+ position: relative;
+ width: 300px;
+ height: 200px;
+ align-items: start;
+ justify-items: start;
+}
+
+.grid > :nth-child(1) { background-color: blue; }
+.grid > :nth-child(2) { background-color: magenta; }
+.grid > :nth-child(3) { background-color: orange; }
+
+</style>
+</head>
+<body onload="checkLayout('.grid')">
+<p>This test checks that grid sizing works as expected with orthogonal flows and items spanning more than 1 columns or rows.</p>
+
+<div class="container">
+ <p>Blue(LR) - <b>row: 1</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - row: 2 <b>col: 2</b></p>
+ <div class="grid">
+ <div class="verticalLR" style="grid-row: 1; grid-column: 1" data-offset-x="0" data-offset-y="0" data-expected-width="20" data-expected-height="90">XX XXX X XXX XX</div>
+ <div class="" style="grid-row: 1; grid-column: 3" data-offset-x="180" data-offset-y="0" data-expected-width="120" data-expected-height="60">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div>
+ <div class="verticalLR" style="grid-row: 2; grid-column: 2" data-offset-x="20" data-offset-y="90" data-expected-width="160" data-expected-height="110">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX XX X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
+ </div>
+</div>
+
+<div class="container">
+ <p>Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - row: 2 <b>col: 2 / 4</b></p>
+ <div class="grid">
+ <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="150">XX XXX X XXX XX</div>
+ <div class="" style="grid-row: 1; grid-column: 3" data-offset-x="35" data-offset-y="0" data-expected-width="265" data-expected-height="30">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div>
+ <div class="verticalLR" style="grid-row: 2; grid-column: 2 / 4;" data-offset-x="10" data-offset-y="30" data-expected-width="100" data-expected-height="170">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX XX X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
+ </div>
+</div>
+
+<div class="container">
+ <p>Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - <b>row: 1 / 3</b> col: 3 | Orange(LR) - <b>row: 3 col: 2 / 3</b></p>
+ <div class="grid" data-expected-width="300" data-expected-height="200">
+ <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" data-offset-x="0" data-offset-y="0" data-expected-width="20" data-expected-height="110">XX XXX X XXX XX</div>
+ <div class="" style="grid-row: 1 / 3; grid-column: 3" data-offset-x="220" data-offset-y="0" data-expected-width="80" data-expected-height="90">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div>
+ <div class="verticalLR" style="grid-row: 3; grid-column: 2 / 3;" data-offset-x="20" data-offset-y="110" data-expected-width="200" data-expected-height="90">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX XX X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
+ </div>
+</div>
+
+<div class="container">
+ <p>Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - row: 2 <b>col: 2 / 3</b></p>
+ <div class="grid">
+ <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="150">XX XXX X XXX XX</div>
+ <div class="" style="grid-row: 1; grid-column: 3" data-offset-x="110" data-offset-y="0" data-expected-width="190" data-expected-height="40">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div>
+ <div class="verticalLR" style="grid-row: 2; grid-column: 2 / 3;" data-offset-x="10" data-offset-y="30" data-expected-width="100" data-expected-height="170">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX XX X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
+ </div>
+</div>
+
+<div class="container">
+ <p>Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - <b>row: 2 / 4 col: 2 / 3</b></p>
+ <div class="grid">
+ <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" data-offset-x="0" data-offset-y="0" data-expected-width="20" data-expected-height="115">XX XXX X XXX XX</div>
+ <div class="" style="grid-row: 1; grid-column: 2" data-offset-x="20" data-offset-y="0" data-expected-width="280" data-expected-height="30">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div>
+ <div class="verticalLR" style="grid-row: 2 / 4; grid-column: 2 / 3;" data-offset-x="20" data-offset-y="30" data-expected-width="100" data-expected-height="170">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX XX X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
+ </div>
+</div>
+</body>
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows-expected.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698