third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 815833005: [css-grid] Handle min-content/max-content with orthogonal flows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 815833005: [css-grid] Handle min-content/max-content with orthogonal flows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch rebased. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index c9cc0244f0b5a1f669ce93d5d3242608eb7719dc..f3891447c2cf8f8d796e52fb91e8c54f109b69ee 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -142,10 +142,15 @@ private:

GridTrackSize gridTrackSize(GridTrackSizingDirection, size_t) const;

+ bool childOverflowingContainingBlockHeight(const LayoutBox&) const;

esprehn 2015/10/30 23:21:31 isFoo() ? I think you want this to be more clear t

+ bool childOverflowingContainingBlockWidth(const LayoutBox&) const;

esprehn 2015/10/30 23:21:31 ditto

+ LayoutUnit overrideContainingBlockLogicalBreadthInlineDirection(const LayoutBox&) const;

+ void setOverrideContainingBlockLogicalBreadthInlineDirection(LayoutBox&, LayoutUnit breadthInLine);

+ LayoutUnit gridAreaBreadthForChildInlineDirection(const LayoutBox&, Vector<GridTrack>&) const;

LayoutUnit logicalHeightForChild(LayoutBox&, Vector<GridTrack>&);

LayoutUnit minSizeForChild(LayoutBox&, GridTrackSizingDirection, Vector<GridTrack>& columnTracks);

- LayoutUnit minContentForChild(LayoutBox&, GridTrackSizingDirection, Vector<GridTrack>& columnTracks);

- LayoutUnit maxContentForChild(LayoutBox&, GridTrackSizingDirection, Vector<GridTrack>& columnTracks);

+ LayoutUnit minContentForChild(LayoutBox&, GridTrackSizingDirection, Vector<GridTrack>&);

+ LayoutUnit maxContentForChild(LayoutBox&, GridTrackSizingDirection, Vector<GridTrack>&);

GridAxisPosition columnAxisPositionForChild(const LayoutBox&) const;

GridAxisPosition rowAxisPositionForChild(const LayoutBox&) const;

LayoutUnit rowAxisOffsetForChild(const LayoutBox&) const;