Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html

Issue 815833005: [css-grid] Handle min-content/max-content with orthogonal flows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch rebased and applied the suggested changes. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows-expected.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <!DOCTYPE html>
2 <link href="resources/grid.css" rel="stylesheet">
3 <link href="resources/grid-alignment.css" rel="stylesheet">
4 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel =stylesheet>
5 <script src="../../resources/check-layout.js"></script>
6 <style>
7 body {
8 margin: 0;
9 }
10
11 .container {
12 position: relative;
13 }
14
15 .grid {
16 font: 10px/1 Ahem;
17 position: relative;
18 }
19
20 .oneMinContentColTwoMinContentRows {
21 font: 50px/1 Ahem;
22 grid: min-content min-content / min-content;
23 }
24
25 .fixedSize {
26 width: 300px;
27 height: 200px;
28 }
29
30 .grid > :nth-child(1) { background-color: blue; }
31 .grid > :nth-child(2) { background-color: magenta; }
32 .grid > :nth-child(3) { background-color: orange; }
33
34 </style>
35 <body onload="checkLayout('.grid')">
36 <p>This test checks that grid sizing works as expected with orthogonal flows and items spanning more than 1 columns or rows. These cases require an extra track- sizing algorithm cycle on the rows to determine final dimensions of the grid.</p >
37
38 <div class="container">
39 <p>Grid: <b>auto</b> | align: <b>start</b> | fixed-sized: <b>300 x 200</b> | font: <b>10px</b> | Blue(LR) - row: 1 col: 1 | Magenta - row: 1 col: 3 | Orange (LR) - row: 2 col: 2</p>
40 <div class="grid fixedSize itemsStart">
41 <div class="verticalLR" style="grid-row: 1; grid-column: 1" dat a-offset-x="0" data-offset-y="0" data-expected-width="20" data-expected-hei ght="105">XX XXX X XXX XX</div>
42 <div class="" style="grid-row: 1; grid-column: 3" dat a-offset-x="180" data-offset-y="0" data-expected-width="120" data-expected-hei ght="60">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div >
43 <div class="verticalLR" style="grid-row: 2; grid-column: 2" dat a-offset-x="20" data-offset-y="105" data-expected-width="200" data-expected-he ight="95">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX X X X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
44 </div>
45 </div>
46
47 <div class="container">
48 <p>Grid: <b>auto</b> | align: <b>start</b> | fixed-sized: <b>300 x 200</b> | font: <b>10px</b> | Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - row: 2 <b>col: 2 / 4</b></p>
49 <div class="grid fixedSize itemsStart">
50 <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" dat a-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-hei ght="150">XX XXX X XXX XX</div>
51 <div class="" style="grid-row: 1; grid-column: 3" dat a-offset-x="35" data-offset-y="0" data-expected-width="265" data-expected-hei ght="30">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div >
52 <div class="verticalLR" style="grid-row: 2; grid-column: 2 / 4;" dat a-offset-x="10" data-offset-y="30" data-expected-width="100" data-expected-hei ght="170">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX X X X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
53 </div>
54 </div>
55
56 <div class="container">
57 <p>Grid: <b>auto</b> | align: <b>start</b> | fixed-sized: <b>300 x 200</b> | font: <b>10px</b> | Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - <b>row: 1 / 3</b> col: 3 | Orange(LR) - <b>row: 3 col: 2 / 3</b></p>
58 <div class="grid fixedSize itemsStart" data-expected-width="300" data-expect ed-height="200">
59 <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" dat a-offset-x="0" data-offset-y="0" data-expected-width="20" data-expected-hei ght="130">XX XXX X XXX XX</div>
60 <div class="" style="grid-row: 1 / 3; grid-column: 3" dat a-offset-x="220" data-offset-y="0" data-expected-width="80" data-expected-hei ght="90">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div >
61 <div class="verticalLR" style="grid-row: 3; grid-column: 2 / 3;" dat a-offset-x="20" data-offset-y="130" data-expected-width="250" data-expected-hei ght="70">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX XX X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
62 </div>
63 </div>
64
65 <div class="container">
66 <p>Grid: <b>auto</b> | align: <b>start</b> | fixed-sized: <b>300 x 200</b> | font: <b>10px</b> | Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - row: 2 <b>col: 2 / 3</b></p>
67 <div class="grid fixedSize itemsStart">
68 <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" dat a-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-hei ght="150">XX XXX X XXX XX</div>
69 <div class="" style="grid-row: 1; grid-column: 3" dat a-offset-x="110" data-offset-y="0" data-expected-width="190" data-expected-hei ght="40">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div >
70 <div class="verticalLR" style="grid-row: 2; grid-column: 2 / 3;" dat a-offset-x="10" data-offset-y="40" data-expected-width="110" data-expected-hei ght="160">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX X X X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
71 </div>
72 </div>
73
74 <div class="container">
75 <p>Grid: <b>auto</b> | align: <b>start</b> | fixed-sized: <b>300 x 200</b> | font: <b>10px</b> | Blue(LR) - <b>row: 1 / 3</b> col: 1 | Magenta - row: 1 col: 3 | Orange(LR) - <b>row: 2 / 4 col: 2 / 3</b></p>
76 <div class="grid fixedSize itemsStart">
77 <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" dat a-offset-x="0" data-offset-y="0" data-expected-width="20" data-expected-hei ght="115">XX XXX X XXX XX</div>
78 <div class="" style="grid-row: 1; grid-column: 2" dat a-offset-x="20" data-offset-y="0" data-expected-width="280" data-expected-hei ght="30">XXXX XX X XX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX X XXX XX XX</div >
79 <div class="verticalLR" style="grid-row: 2 / 4; grid-column: 2 / 3;" dat a-offset-x="20" data-offset-y="30" data-expected-width="100" data-expected-hei ght="170">XXX X XXX XXX XXX XX X XXXXX XXX XX X XXXXX XX X XX XX X XXX XXX XXX X X X XXXX XXX XXX XXX XX X XXX XX XXXXX XXX XXX XX X XXX XX XXX XXX XXX XX X XXX XX X XXX XX XX</div>
80 </div>
81 </div>
82
83 <p>Grid: <b>min-content</b> / <b>min-content min-content</b> | align: <b>stretch </b> | content-sized: <b>fit-content x auto</b> | font: <b>50px</b> | Blue(LR) - <b>row: 1 / 3</b> col: 1 - <b>XX X X</b> | Magenta - row: 1 col: 1 - <b>X X</b> </p>
84 <div class="grid itemsStart oneMinContentColTwoMinContentRows fit-content" data- expected-width="50" data-expected-height="100">
85 <div class="verticalLR" style="grid-row: 1 / 3; grid-column: 1" data-exp ected-width="150" data-expected-height="100">XX X X</div>
86 <div class="" style="grid-row: 1; grid-column: 1" data-exp ected-width="150" data-expected-height="50">X X</div>
87 </div>
88
89 </body>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows-expected.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698