Issue 815833002: [Android] Make menu-dragging less sensitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 815833002: [Android] Make menu-dragging less sensitive. (Closed)

Created:
6 years ago by Kibeom Kim (inactive)

Modified:
6 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Target Ref:
refs/pending/branch-heads/2214

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Make menu-dragging less sensitive. It was easy to trigger menu-dragging logic when user just intends to tap on the menu button. Changed the logic so that it matches ListPopupWindow#ForwardingListener implementation and less sensitive. BUG=434501 TBR=tedchoc Review URL: https://codereview.chromium.org/752683004 Cr-Commit-Position: refs/heads/master@{#305383} (cherry picked from commit 24022d99b8447f4699bf6ea57fff299d1d2f8702) Committed: https://chromium.googlesource.com/chromium/src/+/a11ead6a3cae7d2b56f17deced6d9854cd7e80a4

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -37 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java	View	5 chunks	+16 lines, -14 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java	View	8 chunks	+28 lines, -21 lines	0 comments	Download
M	chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Kibeom Kim (inactive)

6 years ago (2014-12-18 19:30:30 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a11ead6a3cae7d2b56f17deced6d9854cd7e80a4 (presubmit successful).

Expand Messages | Collapse Messages