For faked key events from virtual keyboard, the character is set but dom key is not set. In such ca…

chrome/browser/chromeos/input_method/input_method_engine.cc

Index: chrome/browser/chromeos/input_method/input_method_engine.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc
index 6689b74f020f941f7079304e6ac9b36f7f5bd51c..5572736318ba8d52a0655bfdddf319d57211bd92 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc
@@ -320,18 +320,21 @@ bool InputMethodEngine::SendKeyEvents(
     flags |= event.shift_key ? ui::EF_SHIFT_DOWN     : ui::EF_NONE;
     flags |= event.caps_lock ? ui::EF_CAPS_LOCK_DOWN : ui::EF_NONE;
 
-    ui::KeyEvent ui_event(
-        type,
-        key_code,
-        ui::KeycodeConverter::CodeStringToDomCode(event.code.c_str()),
-        flags);
+    base::char16 ch = 0;
     // 4-bytes UTF-8 string is at least 2-characters UTF-16 string.
     // And Key char can only be single UTF-16 character.
     if (!event.key.empty() && event.key.size() < 4) {
       base::string16 key_char = base::UTF8ToUTF16(event.key);
       if (key_char.size() == 1)
-        ui_event.set_character(key_char[0]);
+        ch = key_char[0];
     }
+    ui::KeyEvent ui_event(
+        type,
+        key_code,
+        ui::KeycodeConverter::CodeStringToDomCode(event.code.c_str()),
+        flags,
+        ui::KeycodeConverter::KeyStringToDomKey(event.key.c_str()),
+        ch);

[kpschoedel, 2014/12/19 16:08:51]

I think eventually we want something like:

    ui::DomKey key = ui::DomKey::NONE;
    base::char16 ch = 0;
    if (!event.key.empty() && event.key.size() < 4) {
      base::string16 key_char = base::UTF8ToUTF16(event.key);
      if (key_char.size() == 1) {
        key = ui::DomKey::CHARACTER;
        ch = key_char[0];
      }
    }
    if (key == ui::DomKey::NONE) {
      key = ui::KeycodeConverter::KeyStringToDomKey(event.key.c_str());
      if (key == ui::DomKey::NONE)
        key = ui::DomKey::UNIDENTIFIED;
    }
    ui::KeyEvent ui_event(
        type,
        key_code,
        ui::KeycodeConverter::CodeStringToDomCode(event.code.c_str()),
        flags,
        key,
        ch);

... but I don't think it's necessary to change it now. I've started working
through the rest of the 'incomplete' KeyEvent constructors, and I think we will
end up with a utility function for this, mapping a web DOM |key| string to a
(DomKey, character) pair.

[Shu Chen, 2014/12/20 11:38:11]

ACK. Thanks & looking forward to the dom key is fully supported for non-ozone
platforms.

     base::AutoReset<const ui::KeyEvent*> reset_sent_key(&sent_key_event_,
                                                         &ui_event);
     ui::EventDispatchDetails details = dispatcher->OnEventFromSource(&ui_event);