Revert of [turbofan] simplify gap ordering

Revert of [turbofan] simplify gap ordering (patchset #2 id:20001 of https://codereview.chromium.org/810013002/)

Reason for revert:
Revert for breaking emscripten bullet with turbofan on android arm64.

Original issue's description:
> [turbofan] simplify gap ordering
>
> BUG=
>
> Committed: https://crrev.com/70b5eb47b39acbf31746f4a116a9b3ce2730218a
> Cr-Commit-Position: refs/heads/master@{#25865}

TBR=bmeurer@chromium.org,dcarney@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/1f44e7267ef86e80312397ba954217f960709799
Cr-Commit-Position: refs/heads/master@{#25888}

[Michael Achenbach, 2014-12-18 14:46:21]

Created Revert of [turbofan] simplify gap ordering

[commit-bot: I haz the power, 2014-12-18 14:47:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815743002/1

[commit-bot: I haz the power, 2014-12-18 14:47:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-18 14:47:09]

Failed to apply patch for src/compiler/instruction.cc:
While running git apply --index -3 -p1;
  error: patch failed: src/compiler/instruction.cc:287
  Falling back to three-way merge...
  Applied patch to 'src/compiler/instruction.cc' with conflicts.
  U src/compiler/instruction.cc

Patch:       src/compiler/instruction.cc
Index: src/compiler/instruction.cc
diff --git a/src/compiler/instruction.cc b/src/compiler/instruction.cc
index
86550d0e1d3291538029afa4152d9d94a56fd178..827cacf665107f13b0f49315c02f713a8fa5277c
100644
--- a/src/compiler/instruction.cc
+++ b/src/compiler/instruction.cc
@@ -287,7 +287,7 @@
 
   if (instr.IsGapMoves()) {
     const GapInstruction* gap = GapInstruction::cast(&instr);
-    os << "gap ";
+    os << (instr.IsBlockStart() ? " block-start" : "gap ");
     for (int i = GapInstruction::FIRST_INNER_POSITION;
          i <= GapInstruction::LAST_INNER_POSITION; i++) {
       os << "(";
@@ -443,10 +443,10 @@
 }
 
 
-GapInstruction* InstructionSequence::GetBlockStart(
+BlockStartInstruction* InstructionSequence::GetBlockStart(
     BasicBlock::RpoNumber rpo) const {
   const InstructionBlock* block = InstructionBlockAt(rpo);
-  return GapInstruction::cast(InstructionAt(block->code_start()));
+  return BlockStartInstruction::cast(InstructionAt(block->code_start()));
 }
 
 
@@ -456,26 +456,26 @@
   int code_start = static_cast<int>(instructions_.size());
   block->set_code_start(code_start);
   block_starts_.push_back(code_start);
+  BlockStartInstruction* block_start = BlockStartInstruction::New(zone());
+  AddInstruction(block_start);
 }
 
 
 void InstructionSequence::EndBlock(BasicBlock::RpoNumber rpo) {
   int end = static_cast<int>(instructions_.size());
   InstructionBlock* block = InstructionBlockAt(rpo);
-  if (block->code_start() == end) {  // Empty block.  Insert a nop.
-    AddInstruction(Instruction::New(zone(), kArchNop));
-    end = static_cast<int>(instructions_.size());
-  }
   DCHECK(block->code_start() >= 0 && block->code_start() < end);
   block->set_code_end(end);
 }
 
 
 int InstructionSequence::AddInstruction(Instruction* instr) {
+  // TODO(titzer): the order of these gaps is a holdover from Lithium.
   GapInstruction* gap = GapInstruction::New(zone());
-  instructions_.push_back(gap);
+  if (instr->IsControl()) instructions_.push_back(gap);
   int index = static_cast<int>(instructions_.size());
   instructions_.push_back(instr);
+  if (!instr->IsControl()) instructions_.push_back(gap);
   if (instr->NeedsPointerMap()) {
     DCHECK(instr->pointer_map() == NULL);
     PointerMap* pointer_map = new (zone()) PointerMap(zone());

[Michael Achenbach, 2014-12-18 15:49:28]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2014-12-18 15:49:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815743002/1

[commit-bot: I haz the power, 2014-12-18 15:49:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-18 18:05:40]

Patchset 1 (id:??) landed as
https://crrev.com/1f44e7267ef86e80312397ba954217f960709799
Cr-Commit-Position: refs/heads/master@{#25888}