pkg/analysis_server/lib/src/services/completion/imported_computer.dart - Issue 815683002: support part file completions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 815683002: support part file completions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

index 0d39c0bae706610f99c6712c02b26deee41b52fa..c32cf32b81696bb858446dfd378dbf8e5b0569d7 100644

--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

@@ -93,9 +93,12 @@ class _ImportedSuggestionBuilder implements SuggestionBuilder {

Future future = null;

if (!cache.isImportInfoCached(request.unit)) {

- future = cache.computeImportInfo(request.unit, request.searchEngine);

+ future = cache.computeImportInfo(

+ request.unit,

+ request.searchEngine,

+ shouldWaitForLowPrioritySuggestions);

}

- if (future != null && shouldWaitForLowPrioritySuggestions) {

+ if (future != null) {

return future.then(addSuggestions);

}

return addSuggestions(true);