Issue 815643004: Move ContentSettingsUsagesState to the component.

Issue 815643004: Move ContentSettingsUsagesState to the component. (Closed)

Created:
5 years, 11 months ago by vasilii

Modified:
5 years, 11 months ago

Reviewers:
vabr (Chromium), Bernhard Bauer, timvolodine

CC:
chromium-reviews, markusheintz_, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Move ContentSettingsUsagesState to the component. BUG=387064 Committed: https://crrev.com/558f1a2463cf29d8cb6f7e510d8fc128d6f5193d Cr-Commit-Position: refs/heads/master@{#311434}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -209 lines)			Patch
D	chrome/browser/content_settings/content_settings_usages_state.h	View	1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/browser/content_settings/content_settings_usages_state.cc	View	1 chunk	+0 lines, -112 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_usages_state_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/geolocation/geolocation_browsertest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/content_settings.gypi	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	components/content_settings/core/browser/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	components/content_settings/core/browser/content_settings_usages_state.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/content_settings/core/browser/content_settings_usages_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (3 generated)

vasilii

Hi guys, please review timvolodine@: chrome/browser/geolocation others: everything

5 years, 11 months ago (2015-01-13 14:17:41 UTC) #3

timvolodine

On 2015/01/13 23:17:24, Bernhard Bauer wrote: > LGTM chrome/browser/geolocation -- lgtm

5 years, 11 months ago (2015-01-14 01:44:11 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815643004/1

5 years, 11 months ago (2015-01-14 09:26:03 UTC) #8

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 09:31:22 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/558f1a2463cf29d8cb6f7e510d8fc128d6f5193d
Cr-Commit-Position: refs/heads/master@{#311434}