Issue 815613002: Fix attribute selectors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 815613002: Fix attribute selectors. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix attribute selectors. There was a return missing in SelectorChecker, we were also making the attribute names lowercase which is not neccesary in Sky. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c03bdc8f5487efa108e0e83e403192b2f411fa15

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
M	sky/engine/core/css/SelectorChecker.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSGrammar.y	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/tests/lowlevel/query-selector.sky	View	2 chunks	+13 lines, -2 lines	0 comments	Download
M	sky/tests/lowlevel/query-selector-expected.txt	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 4 (2 generated)

esprehn

6 years ago (2014-12-17 22:00:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c03bdc8f5487efa108e0e83e403192b2f411fa15 (presubmit successful).