Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: tools/perf/page_sets/key_silk_cases.py

Issue 815573004: [Telemetry] Fix swipe_to_dimiss page in key_silk_cases and disable slide_drawer page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_silk_cases.py
diff --git a/tools/perf/page_sets/key_silk_cases.py b/tools/perf/page_sets/key_silk_cases.py
index 9dfe8cc90011ec39f0863d2bba13cc2a65d12a02..c906b70b88fe3e5dba01d85029200d14aaeb16e6 100644
--- a/tools/perf/page_sets/key_silk_cases.py
+++ b/tools/perf/page_sets/key_silk_cases.py
@@ -285,10 +285,6 @@ class Page16(KeySilkCasesPage):
direction='left', distance=400, speed_in_pixels_per_second=5000,
element_function='document.getElementsByClassName("message")[2]')
interaction.End()
- interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
- action_runner.WaitForJavaScriptCondition(
- 'document.getElementsByClassName("message").length < 18')
- interaction.End()
def RunPageInteractions(self, action_runner):
self.SwipeToDismiss(action_runner)
@@ -676,7 +672,8 @@ class KeySilkCasesPageSet(page_set_module.PageSet):
self.AddUserStory(Page16(self))
self.AddUserStory(Page17(self))
self.AddUserStory(Page18(self))
- self.AddUserStory(Page19(self))
+ # Missing frames during tap interaction; crbug.com/446332
+ # self.AddUserStory(Page19(self))
self.AddUserStory(Page20(self))
self.AddUserStory(GwsGoogleExpansion(self))
self.AddUserStory(GwsBoogieExpansion(self))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698