Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 815573004: [Telemetry] Fix swipe_to_dimiss page in key_silk_cases and disable slide_drawer page. (Closed)

Created:
5 years, 11 months ago by nednguyen
Modified:
5 years, 11 months ago
Reviewers:
sullivan, ajuma, tonyg, ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix swipe_to_dimiss page in key_silk_cases and disable slide_drawer page. BUG=446332 Committed: https://crrev.com/17f542c223a72cdd2e759e199bfb8a730bdde890 Cr-Commit-Position: refs/heads/master@{#310134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M tools/perf/page_sets/key_silk_cases.py View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
nednguyen
5 years, 11 months ago (2015-01-06 16:48:07 UTC) #2
sullivan
lgtm Thanks for looking into this!
5 years, 11 months ago (2015-01-06 16:51:45 UTC) #3
sullivan
+ajuma, who re-enabled slide_drawer in https://codereview.chromium.org/791183002
5 years, 11 months ago (2015-01-06 16:55:24 UTC) #4
ajuma
lgtm, thanks for tracking this down! I suspect the fix for slide_drawer is to move ...
5 years, 11 months ago (2015-01-06 17:04:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815573004/1
5 years, 11 months ago (2015-01-06 19:10:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 20:39:36 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 20:40:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17f542c223a72cdd2e759e199bfb8a730bdde890
Cr-Commit-Position: refs/heads/master@{#310134}

Powered by Google App Engine
This is Rietveld 408576698