Separating ARIA, HTML & event AX test.

Separating ARIA, HTML & event AX test.

The number of AX tests in content/test/data/accessibility is getting too large.
So, separating by creating new dir accessibility/aria, accessibility/html and accessibility/event.

BUG=none

Committed: https://crrev.com/199e7aea90d766414caca02e73ee803c3987064b
Cr-Commit-Position: refs/heads/master@{#309670}

[shreeramk, 2014-12-19 18:18:08]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-12-19 18:18:28]

Please review.

Thanks!!

https://codereview.chromium.org/815463006/diff/10001/content/browser/accessib...
File content/browser/accessibility/dump_accessibility_browsertest_base.cc
(right):

https://codereview.chromium.org/815463006/diff/10001/content/browser/accessib...
content/browser/accessibility/dump_accessibility_browsertest_base.cc:197: GURL
url = GetTestUrl(file_dir, file_path.BaseName().MaybeAsASCII().c_str());
file_dir is needed to get the test url using GetTestUrl() API. And also the
parameter which accepts this value is of type char.
So, I am sending the string which contains slash('/'). May be that'd cause some
problem. I have ran the bots to check that.

[shreeramk, 2014-12-19 18:19:56]

Please review.

Thanks!!!

[dmazzoni, 2014-12-22 08:01:20]

lgtm

https://codereview.chromium.org/815463006/diff/20001/content/browser/accessib...
File content/browser/accessibility/dump_accessibility_browsertest_base.h
(right):

https://codereview.chromium.org/815463006/diff/20001/content/browser/accessib...
content/browser/accessibility/dump_accessibility_browsertest_base.h:31: void
RunEventTest(const base::FilePath::CharType* file_path);
This doesn't belong in DumpAccessibilityTestBase, it belongs in
DumpAccessibilityEventsTest

Same with Aria and Html - they belong in DumpAccessibilityTreeTest.

[shreeramk, 2014-12-22 16:56:25]

I ll update this patch tmrw when my other patches which are modifying the files
in this directory are merged.

https://codereview.chromium.org/815463006/diff/20001/content/browser/accessib...
File content/browser/accessibility/dump_accessibility_browsertest_base.h
(right):

https://codereview.chromium.org/815463006/diff/20001/content/browser/accessib...
content/browser/accessibility/dump_accessibility_browsertest_base.h:31: void
RunEventTest(const base::FilePath::CharType* file_path);
On 2014/12/22 08:01:20, dmazzoni wrote:
> This doesn't belong in DumpAccessibilityTestBase, it belongs in
> DumpAccessibilityEventsTest
> 
> Same with Aria and Html - they belong in DumpAccessibilityTreeTest.

Oops sorry. Will take care in next patchset.

[shreeramk, 2014-12-23 04:52:24]

@Dominic: Could you please take a look at this try bot? 
Sometimes the mac bot is failing for some AX Test...Not able to find out the
reason for same.
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_dbg/...

[dmazzoni, 2014-12-23 08:14:30]

It looks to me like it's not getting the new content/test/data files you're
adding.

Sometimes it's a problem with the .isolate file - what happens is that the
code is compiled on one machine, but then the compiled binary and test
inputs are all copied to several other machines to run the tests. That
looks like the error you'd get if it didn't copy
content/test/data/accessibility/html, for example.

I don't see what's wrong, though.

Can you try it with a really small change - like one that just moves one
test file? If it still fails, we may need to ask for help.

- Dominic


On Mon, Dec 22, 2014 at 8:52 PM, <shreeram.k@samsung.com> wrote:
>
> @Dominic: Could you please take a look at this try bot?
> Sometimes the mac bot is failing for some AX Test...Not able to find out
> the
> reason for same.
> http://build.chromium.org/p/tryserver.chromium.mac/
> builders/mac_chromium_dbg/builds/906
>
>
> https://codereview.chromium.org/815463006/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-12-23 08:38:50]

https://codereview.chromium.org/815463006/diff/40001/content/browser/accessib...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/815463006/diff/40001/content/browser/accessib...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:75:
RunTest(aria_file, "accessibility/aria");
This can cause any error like that? Because of slash?

[dmazzoni, 2014-12-23 08:41:01]

On Tue, Dec 23, 2014 at 12:38 AM, <shreeram.k@samsung.com> wrote:
>
> https://codereview.chromium.org/815463006/diff/40001/
> content/browser/accessibility/dump_accessibility_tree_
> browsertest.cc#newcode75
> content/browser/accessibility/dump_accessibility_tree_browsertest.cc:75:
> RunTest(aria_file, "accessibility/aria");
> This can cause any error like that? Because of slash?


It shouldn't! But that's what it looks like - like the new files weren't
being copied over.

It could just be a problem on that particular machine - if the test is
passing on all of the Windows bots, that's possible.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-12-23 09:01:17]

Can we use this flag to separate the call for RunTest()?

#if defined(OS_WIN)

#elif defined(OS_POSIX)

#endif


On 2014/12/23 08:41:01, dmazzoni wrote:
> On Tue, Dec 23, 2014 at 12:38 AM, <mailto:shreeram.k@samsung.com> wrote:
> >
> > https://codereview.chromium.org/815463006/diff/40001/
> > content/browser/accessibility/dump_accessibility_tree_
> > browsertest.cc#newcode75
> > content/browser/accessibility/dump_accessibility_tree_browsertest.cc:75:
> > RunTest(aria_file, "accessibility/aria");
> > This can cause any error like that? Because of slash?
> 
> 
> It shouldn't! But that's what it looks like - like the new files weren't
> being copied over.
> 
> It could just be a problem on that particular machine - if the test is
> passing on all of the Windows bots, that's possible.
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-12-24 19:31:17]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-12-24 19:32:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815463006/40001

[commit-bot: I haz the power, 2014-12-24 19:41:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 19:41:32]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[shreeramk, 2014-12-26 09:07:19]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-12-26 09:07:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815463006/50001

[commit-bot: I haz the power, 2014-12-26 10:47:17]

Committed patchset #6 (id:50001)

[commit-bot: I haz the power, 2014-12-26 10:47:54]

Patchset 6 (id:??) landed as
https://crrev.com/199e7aea90d766414caca02e73ee803c3987064b
Cr-Commit-Position: refs/heads/master@{#309670}