Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 815363003: FrameView now notifies ScrollCoorinator of changes in its scrollable area set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 class LocalFrame; 52 class LocalFrame;
53 class KURL; 53 class KURL;
54 class Node; 54 class Node;
55 class Page; 55 class Page;
56 class RenderBox; 56 class RenderBox;
57 class RenderEmbeddedObject; 57 class RenderEmbeddedObject;
58 class RenderObject; 58 class RenderObject;
59 class RenderPart; 59 class RenderPart;
60 class RenderScrollbarPart; 60 class RenderScrollbarPart;
61 class RenderView; 61 class RenderView;
62 class ScrollingCoordinator;
62 struct CompositedSelectionBound; 63 struct CompositedSelectionBound;
63 64
64 typedef unsigned long long DOMTimeStamp; 65 typedef unsigned long long DOMTimeStamp;
65 66
66 class FrameView final : public Widget, public ScrollableArea { 67 class FrameView final : public Widget, public ScrollableArea {
67 public: 68 public:
68 friend class RenderView; 69 friend class RenderView;
69 friend class Internals; 70 friend class Internals;
70 71
71 static PassRefPtrWillBeRawPtr<FrameView> create(LocalFrame*); 72 static PassRefPtrWillBeRawPtr<FrameView> create(LocalFrame*);
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 // notifyScrollPositionChanged...there's too many ways to scroll this class. This needs 679 // notifyScrollPositionChanged...there's too many ways to scroll this class. This needs
679 // some cleanup. 680 // some cleanup.
680 void setScrollOffsetFromUpdateScrollbars(const DoubleSize&); 681 void setScrollOffsetFromUpdateScrollbars(const DoubleSize&);
681 682
682 IntRect rectToCopyOnScroll() const; 683 IntRect rectToCopyOnScroll() const;
683 684
684 void updateOverhangAreas(); 685 void updateOverhangAreas();
685 686
686 bool isFrameViewScrollbar(const Widget* child) const { return horizontalScro llbar() == child || verticalScrollbar() == child; } 687 bool isFrameViewScrollbar(const Widget* child) const { return horizontalScro llbar() == child || verticalScrollbar() == child; }
687 688
689 ScrollingCoordinator* scrollingCoordinator();
690
688 static double s_currentFrameTimeStamp; // used for detecting decoded resourc e thrash in the cache 691 static double s_currentFrameTimeStamp; // used for detecting decoded resourc e thrash in the cache
689 692
690 LayoutSize m_size; 693 LayoutSize m_size;
691 694
692 typedef WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject>> Embedded ObjectSet; 695 typedef WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject>> Embedded ObjectSet;
693 WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject>> m_partUpdateSet; 696 WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject>> m_partUpdateSet;
694 697
695 // FIXME: These are just "children" of the FrameView and should be RefPtrWil lBeMember<Widget> instead. 698 // FIXME: These are just "children" of the FrameView and should be RefPtrWil lBeMember<Widget> instead.
696 WillBeHeapHashSet<RefPtrWillBeMember<RenderPart>> m_parts; 699 WillBeHeapHashSet<RefPtrWillBeMember<RenderPart>> m_parts;
697 700
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
861 } 864 }
862 865
863 private: 866 private:
864 RawPtrWillBeMember<FrameView> m_view; 867 RawPtrWillBeMember<FrameView> m_view;
865 bool m_originalValue; 868 bool m_originalValue;
866 }; 869 };
867 870
868 } // namespace blink 871 } // namespace blink
869 872
870 #endif // FrameView_h 873 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698