Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 815353002: Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e (Closed)

Created:
6 years ago by Lei Zhang
Modified:
6 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e 59dffb6 Fix new third_party/BUILD.gn to use the right build config. 06b087a Set the freetype options missing in the recent update. b3a3230 Add the license back to ftmodule.h after the freetype 2.5.4 upgrade. a09d50d Transform font size to user space for valid text size comparison. e4fc5ce Update freetype to 2.5.4. BUG=407341, 438441, 444243 TBR=tsepez@chromium.org Committed: https://crrev.com/43a66cb1bff61ab967d767160287c0d9129128b8 Cr-Commit-Position: refs/heads/master@{#309342}

Patch Set 1 #

Patch Set 2 : fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Lei Zhang
o/~ One more time, let's do it again. o/~
6 years ago (2014-12-20 03:41:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815353002/1
6 years ago (2014-12-20 03:41:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/28248) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/44992)
6 years ago (2014-12-20 03:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815353002/20001
6 years ago (2014-12-20 05:29:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-20 06:28:52 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/43a66cb1bff61ab967d767160287c0d9129128b8 Cr-Commit-Position: refs/heads/master@{#309342}
6 years ago (2014-12-20 06:29:38 UTC) #9
Michael Achenbach
6 years ago (2014-12-20 15:57:47 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/821543002/ by machenbach@chromium.org.

The reason for reverting is: Breaks compilation on Win8 GN:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20GN&number....

Powered by Google App Engine
This is Rietveld 408576698