chrome/android/BUILD.gn - Issue 815343005: Clean up geolocation code now that it's all upstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 815343005: Clean up geolocation code now that it's all upstream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java » ('j') | chrome/browser/android/location_settings_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index ecc97345b7d3f60031b5441cfca4aa245d97eade..315157898d9c6507f691c87c609e04fc43774e75 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -168,10 +168,10 @@ java_cpp_template("resource_id_javagen") {

# GYP: //chrome/chrome_shell.gypi:libchromeshell_base

static_library("chrome_shell_base") {

- sources = [

- "shell/chrome_shell_google_location_settings_helper.cc",

- "shell/chrome_shell_google_location_settings_helper.h",

- ]

+ #sources = [

Michael van Ouwerkerk 2015/01/19 12:03:14 Did you mean to delete this section?

newt (away) 2015/01/20 16:58:51 Yes, though I'm wondering if I can/should delete t

+ # "shell/chrome_shell_google_location_settings_helper.cc",

+ # "shell/chrome_shell_google_location_settings_helper.h",

+ #]

deps = [

"//chrome/browser/ui",