Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: cc/base/swap_promise.h

Issue 81533002: Use LatencyInfoSwapPromise to track LatencyInfo through compositor (Closed) Base URL: http://git.chromium.org/chromium/src.git@swap_promise_2
Patch Set: reupload Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/base/swap_promise.h
diff --git a/cc/base/swap_promise.h b/cc/base/swap_promise.h
index 90bf6af53a6a0909484cd897b1ccab6a2cbe3844..1d4c2473e5216d10bd2e78d174737b9d72b33124 100644
--- a/cc/base/swap_promise.h
+++ b/cc/base/swap_promise.h
@@ -5,6 +5,8 @@
#ifndef CC_BASE_SWAP_PROMISE_H_
#define CC_BASE_SWAP_PROMISE_H_
+#include "cc/output/compositor_frame_metadata.h"
+
namespace cc {
const unsigned int kMaxQueuedSwapPromiseNumber = 100;
@@ -29,8 +31,10 @@ const unsigned int kMaxQueuedSwapPromiseNumber = 100;
// DidSwap() and DidNotSwap().
class SwapPromise {
public:
- SwapPromise() {}
- virtual ~SwapPromise() {}
+ enum SwapPromiseType {
danakj 2013/11/27 20:11:42 This is no longer needed
Yufeng Shen (Slow to review) 2013/11/27 20:18:52 Done.
+ SWAP_PROMISE_UNKNOWN,
+ SWAP_PROMISE_LATENCY_INFO,
+ };
enum DidNotSwapReason {
DID_NOT_SWAP_UNKNOWN,
@@ -39,8 +43,18 @@ class SwapPromise {
SWAP_PROMISE_LIST_OVERFLOW,
};
- virtual void DidSwap() = 0;
+ explicit SwapPromise(SwapPromiseType type) : type_(type) {}
+ virtual ~SwapPromise() {}
+
+ SwapPromiseType type() {
+ return type_;
+ }
+
+ virtual void DidSwap(CompositorFrameMetadata* metadata) = 0;
virtual void DidNotSwap(DidNotSwapReason reason) = 0;
+
+ protected:
+ SwapPromiseType type_;
danakj 2013/11/27 20:11:42 The type should be able to go away now.
Yufeng Shen (Slow to review) 2013/11/27 20:18:52 Done.
};
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698