Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 815293002: Support unprefixed EME in HTMLViewer. (Closed)

Created:
6 years ago by xhwang
Modified:
6 years ago
Reviewers:
jrummell, jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ddorwin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support unprefixed EME in HTMLViewer. Tested with: out/GN/mojo_shell http://<host>/LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src.html --args-for='mojo://html_viewer --v=3 --enable-encrypted-media' TBR=jamesr@chromium.org BUG=444205 TEST=See above. Committed: https://crrev.com/f549b3d45ef6c93c41e101d1d0dbeebffbad7222 Cr-Commit-Position: refs/heads/master@{#309565}

Patch Set 1 #

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -15 lines) Patch
M mojo/services/html_viewer/html_document.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document.cc View 1 5 chunks +18 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/webmimeregistry_impl.cc View 1 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xhwang
jrummell: Please review from EME's perspective. jamesr: Please review from HTMLViewer's perspective. ddorwin: FYI
6 years ago (2014-12-20 00:16:04 UTC) #2
xhwang
rebase only
6 years ago (2014-12-22 18:06:09 UTC) #3
jrummell
lgtm.
6 years ago (2014-12-23 01:01:04 UTC) #4
xhwang
TBRing jamesr...
6 years ago (2014-12-23 17:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815293002/20001
6 years ago (2014-12-23 17:55:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-23 18:44:33 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-23 18:45:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f549b3d45ef6c93c41e101d1d0dbeebffbad7222
Cr-Commit-Position: refs/heads/master@{#309565}

Powered by Google App Engine
This is Rietveld 408576698