Remove and deprecate SEARCH_SUGGEST_ANSWER

components/omnibox/autocomplete_match_type.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_AUTOCOMPLETE_MATCH_TYPE_H_
 #define COMPONENTS_OMNIBOX_AUTOCOMPLETE_MATCH_TYPE_H_
 
 #include <string>
 
 struct AutocompleteMatchType {
   // Type of AutocompleteMatch. Typedef'ed in autocomplete_match.h. Defined here
   // to pass the type details back and forth between the browser and renderer.
   //
   // These values are stored in ShortcutsDatabase and in GetDemotionsByType()

[Mark P, 2015/01/30 23:13:27]

This comment makes me worried about this action.  Did we talk about this
already?  This type was used in the wild, right?  What's going to happen with
shortcuts with a Type value in its database that no longer exists?  (Or are
these Type values transformed *before* storing in the database?)

[Justin Donnelly, 2015/01/30 23:21:04]

Yeah, you're right. Dave, it looks to me like the right thing to do here is to
update the comment with "(deprecated)" like EXTENSION_APP and
CONTACT_DEPRECATED. Adding _DEPRECATED to the type name seems appropriate as
well.

   // and cannot be renumbered.
   enum Type {
     URL_WHAT_YOU_TYPED    = 0,  // The input as a URL.
     HISTORY_URL           = 1,  // A past page whose URL contains the input.
     HISTORY_TITLE         = 2,  // A past page whose title contains the input.
     HISTORY_BODY          = 3,  // A past page whose body contains the input.
     HISTORY_KEYWORD       = 4,  // A past page whose keyword contains the
                                 // input.
     NAVSUGGEST            = 5,  // A suggested URL.
     SEARCH_WHAT_YOU_TYPED = 6,  // The input as a search query (with the
@@ skipping 10 matching lines @@
     SEARCH_SUGGEST_PROFILE      = 12,  // A personalized suggested search for a
                                        // Google+ profile.
     SEARCH_OTHER_ENGINE         = 13,  // A search with a non-default engine.
     EXTENSION_APP               = 14,  // An Extension App with a title/url that
                                        // contains the input (deprecated).
     CONTACT_DEPRECATED          = 15,  // One of the user's contacts
                                        // (deprecated).
     BOOKMARK_TITLE              = 16,  // A bookmark whose title contains the
                                        // input.
     NAVSUGGEST_PERSONALIZED     = 17,  // A personalized suggestion URL.
-    SEARCH_SUGGEST_ANSWER       = 18,  // A short result for a suggested search.
     NUM_TYPES,
   };
 
   // Converts |type| to a string representation. Used in logging.
   static std::string ToString(AutocompleteMatchType::Type type);
 };
 
 #endif  // COMPONENTS_OMNIBOX_AUTOCOMPLETE_MATCH_TYPE_H_