Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 815223005: Use SkLazyPtr in SkPDFGraphicState.cpp (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkLazyPtr in SkPDFGraphicState.cpp Motivation: currently we rely on mutexes for guarding static initialization. These mutexes will go away. Committed: https://skia.googlesource.com/skia/+/e6ea244717feda4265b7062a0462267a0d9e1753

Patch Set 1 #

Patch Set 2 : fix clang compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -35 lines) Patch
M src/pdf/SkPDFGraphicState.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 5 chunks +44 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hal.canary
5 years, 11 months ago (2015-01-21 18:21:12 UTC) #2
mtklein
lgtm
5 years, 11 months ago (2015-01-21 20:13:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815223005/1
5 years, 11 months ago (2015-01-21 20:14:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1612)
5 years, 11 months ago (2015-01-21 20:17:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815223005/20001
5 years, 11 months ago (2015-01-21 20:42:16 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:13:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e6ea244717feda4265b7062a0462267a0d9e1753

Powered by Google App Engine
This is Rietveld 408576698