Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 815213002: Cause chromium_android recipe to consume device_status_check's json. (Closed)

Created:
6 years ago by tonyg
Modified:
6 years ago
Reviewers:
zty
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Cause chromium_android recipe to consume device_status_check's json. Also, get rid of the list_devices step on chromium.perf. This patch only intends to introduce the json, it doesn't intend any behavior change. Internal expectations are in: https://chromereviews.googleplex.com/135827016 BUG=434013 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293473

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove unneeded coverage #

Patch Set 3 : Add missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1627 lines, -402 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 3 chunks +33 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_adb_vendor_keys_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 1 chunk +29 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
D scripts/slave/recipe_modules/chromium_android/example.expected/tester_no_devices.json View 1 2 2 chunks +27 lines, -1 line 0 comments Download
D scripts/slave/recipe_modules/chromium_android/example.expected/tester_other_device_failure.json View 1 2 2 chunks +27 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/local_test.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 3 chunks +4 lines, -27 lines 0 comments Download
D scripts/slave/recipes/android/perf.expected/device_status_check.json View 1 chunk +0 lines, -143 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_MotoE_Perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus10_Perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus4_Perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_android_nexus5_oilpan_perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_client_v8_Android_Nexus4_Perf.json View 3 chunks +31 lines, -20 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/provision_devices.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe__content_browsertests_failure.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/chromium_linux_Android_Tests.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/chromium_linux_Android_Tests__dbg_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/tryserver_chromium_linux_android_dbg_tests_recipe.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/tryserver_chromium_linux_android_rel_tests_recipe.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp_perf.expected/basic.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_android_nexus5_oilpan_perf.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests__dbg_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_MotoE_Perf.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus10_Perf.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus4_Perf.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_Android_Tests__dbg___JB_Nexus7_2_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_Android_Tests__dbg___KK_Nexus5_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_Tests__dbg___JB_Nexus7_2_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_Tests__dbg___KK_Nexus5_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__jb_nexus7_2_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__jb_nexus7_2__dbg_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__dbg_.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__failing_test.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__forced.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android.json View 1 chunk +30 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 1 chunk +30 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
tonyg
6 years ago (2014-12-19 21:18:46 UTC) #5
zty
lgtm with nit https://codereview.chromium.org/815213002/diff/60001/scripts/slave/recipes/android/perf.py File scripts/slave/recipes/android/perf.py (right): https://codereview.chromium.org/815213002/diff/60001/scripts/slave/recipes/android/perf.py#newcode158 scripts/slave/recipes/android/perf.py:158: yield (api.properties.generic( What coverage does this ...
6 years ago (2014-12-19 21:31:05 UTC) #6
tonyg
https://codereview.chromium.org/815213002/diff/60001/scripts/slave/recipes/android/perf.py File scripts/slave/recipes/android/perf.py (right): https://codereview.chromium.org/815213002/diff/60001/scripts/slave/recipes/android/perf.py#newcode158 scripts/slave/recipes/android/perf.py:158: yield (api.properties.generic( On 2014/12/19 21:31:05, zty wrote: > What ...
6 years ago (2014-12-19 21:34:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815213002/80001
6 years ago (2014-12-19 21:37:06 UTC) #9
commit-bot: I haz the power
Presubmit check for 815213002-80001 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-19 21:39:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815213002/100001
6 years ago (2014-12-19 21:44:37 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-19 21:47:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293473

Powered by Google App Engine
This is Rietveld 408576698