Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3309)

Unified Diff: base/chromeos/memory_pressure_observer_chromeos.h

Issue 815183002: Using the new MemoryPressureListener instead of the LowMemoryObserver when the enhanced memory mana… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/chromeos/memory_pressure_observer_chromeos.h
diff --git a/base/chromeos/memory_pressure_observer_chromeos.h b/base/chromeos/memory_pressure_observer_chromeos.h
index 445119efb73853c1f712dab8c85ad190ddb86f6b..7ecaef85688cb97d3b1402928cd0b2ed0a672066 100644
--- a/base/chromeos/memory_pressure_observer_chromeos.h
+++ b/base/chromeos/memory_pressure_observer_chromeos.h
@@ -24,6 +24,11 @@ class BASE_EXPORT MemoryPressureObserverChromeOS {
MemoryPressureObserverChromeOS();
~MemoryPressureObserverChromeOS();
+ // Redo the memory pressure calculation soon and call again if a critical
+ // memory pressure prevails. Note that this call will trigger an asynchronous
+ // action which gives the system time to release memory back into the pool.
+ void ScheduleEarlyCheck();
+
// Get the current memory pressure level.
base::MemoryPressureListener::MemoryPressureLevel GetCurrentPressureLevel() {
return current_memory_pressure_level_;
@@ -39,8 +44,9 @@ class BASE_EXPORT MemoryPressureObserverChromeOS {
// May be safely called if StartObserving has not been called.
void StopObserving();
- // The function which gets periodically be called to check any changes in the
- // memory pressure.
+ // The function which gets periodically called to check any changes in the
+ // memory pressure. It will report pressure changes as well as continuous
+ // critical pressure levels.
void CheckMemoryPressure();
// The current memory pressure.
@@ -51,6 +57,10 @@ class BASE_EXPORT MemoryPressureObserverChromeOS {
// replaced by a kernel triggered event system (see crbug.com/381196).
base::RepeatingTimer<MemoryPressureObserverChromeOS> timer_;
+ // To slow down the amount of moderate pressure event calls, this counter
+ // gets used to count the number of events since the last event occured.
+ int moderate_pressure_repeat_counter_;
James Cook 2014/12/19 19:38:07 nit: maybe "moderate_pressure_repeat_count_"?
Mr4D (OOO till 08-26) 2014/12/19 23:34:41 Done.
+
DISALLOW_COPY_AND_ASSIGN(MemoryPressureObserverChromeOS);
};
« no previous file with comments | « no previous file | base/chromeos/memory_pressure_observer_chromeos.cc » ('j') | base/chromeos/memory_pressure_observer_chromeos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698