src/ic/arm64/handler-compiler-arm64.cc - Issue 815143002: Use weak cells in CheckPropertyCell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 815143002: Use weak cells in CheckPropertyCell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/arm64/handler-compiler-arm64.cc

diff --git a/src/ic/arm64/handler-compiler-arm64.cc b/src/ic/arm64/handler-compiler-arm64.cc

index 88a5f2229b2f5d200a5b4cfb95d550ea893f1f36..c9385d17b2d3d0e0ab48047e5bf9048f0c225432 100644

--- a/src/ic/arm64/handler-compiler-arm64.cc

+++ b/src/ic/arm64/handler-compiler-arm64.cc

@@ -111,7 +111,8 @@ void PropertyHandlerCompiler::GenerateCheckPropertyCell(

Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name);

DCHECK(cell->value()->IsTheHole());

- __ Mov(scratch, Operand(cell));

+ Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell);

+ __ LoadWeakValue(scratch, weak_cell, miss);

__ Ldr(scratch, FieldMemOperand(scratch, Cell::kValueOffset));

__ JumpIfNotRoot(scratch, Heap::kTheHoleValueRootIndex, miss);

}

« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »