util/win/scoped_handle.cc - Issue 815053004: Switch [String]FileWriter to use new file_io.h functions/types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/win/scoped_handle.cc

Issue 815053004: Switch [String]FileWriter to use new file_io.h functions/types (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@file_io_seek-2

Patch Set: fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/win/scoped_handle.cc

diff --git a/util/win/scoped_handle.cc b/util/win/scoped_handle.cc

index 34c1ec7b9fcf30025cffd040eba69f1151d484d5..5eb440e045da703f76162fe8bc5e84a54b23e77a 100644

--- a/util/win/scoped_handle.cc

+++ b/util/win/scoped_handle.cc

@@ -15,12 +15,13 @@

#include "util/win/scoped_handle.h"

#include "base/logging.h"

+#include "util/file/file_io.h"

namespace crashpad {

namespace internal {

void ScopedFileHANDLECloseTraits::Free(HANDLE handle) {

- PCHECK(CloseHandle(handle));

+ CheckedCloseFile(handle);

}

void ScopedKernelHANDLECloseTraits::Free(HANDLE handle) {

« no previous file with comments | « util/file/string_file_writer.cc ('k') | no next file » | no next file with comments »