tools/generate_dump.cc - Issue 815053004: Switch [String]FileWriter to use new file_io.h functions/types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/generate_dump.cc

Issue 815053004: Switch [String]FileWriter to use new file_io.h functions/types (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@file_io_seek-2

Patch Set: fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/generate_dump.cc

diff --git a/tools/generate_dump.cc b/tools/generate_dump.cc

index c94aa983f7c76480b45c0938fd79ccccbd1b0367..d936149793dd3419b043bdc75882ece35fa2fb59 100644

--- a/tools/generate_dump.cc

+++ b/tools/generate_dump.cc

@@ -152,8 +152,8 @@ int GenerateDumpMain(int argc, char* argv[]) {

FileWriter file_writer;

if (!file_writer.Open(base::FilePath(options.dump_path),

- O_WRONLY | O_CREAT | O_TRUNC,

- 0644)) {

+ FileWriteMode::kTruncateOrCreate,

+ true)) {

return EXIT_FAILURE;

}

« no previous file with comments | « no previous file | util/file/file_io.h » ('j') | no next file with comments »