Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 815003002: Nukes ViewManager arg from ViewManagerDelegate::OnEmbed (Closed)

Created:
6 years ago by sky
Modified:
6 years ago
CC:
esprehn, Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Nukes ViewManager arg from ViewManagerDelegate::OnEmbed It can be obtained from the supplied view, so no reason to include in the arguments. R=ben@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/92643b500cad7348994999efb91ab26d5be896cd

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -121 lines) Patch
M examples/aura_demo/aura_demo.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/browser/browser.cc View 1 4 chunks +2 lines, -8 lines 0 comments Download
M examples/embedded_app/embedded_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ganesh_app/ganesh_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/keyboard/keyboard.cc View 3 chunks +1 line, -7 lines 0 comments Download
M examples/media_viewer/media_viewer.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M examples/nesting_app/nesting_app.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/png_viewer/png_viewer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/recipes/window_manager/main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/sky_compositor_app/sky_compositor_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/window_manager/window_manager.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M examples/wm_flow/app/app.cc View 2 chunks +1 line, -2 lines 0 comments Download
M examples/wm_flow/embedded/embedded.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/wm_flow/wm/wm.cc View 6 chunks +3 lines, -8 lines 0 comments Download
M mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M mojo/services/view_manager/public/cpp/view_manager.h View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/view_manager/public/cpp/view_manager_delegate.h View 1 chunk +4 lines, -8 lines 0 comments Download
M services/window_manager/main.cc View 1 4 chunks +3 lines, -8 lines 0 comments Download
M services/window_manager/window_manager_api_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/window_manager/window_manager_app.h View 3 chunks +5 lines, -3 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 1 6 chunks +12 lines, -14 lines 0 comments Download
M sky/tools/debugger/debugger.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 3 chunks +1 line, -6 lines 0 comments Download
M sky/tools/tester/tester.cc View 4 chunks +1 line, -6 lines 0 comments Download
M sky/viewer/document_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sky
6 years ago (2014-12-18 22:24:30 UTC) #1
Ben Goodger (Google)
lgtm
6 years ago (2014-12-18 22:25:28 UTC) #2
esprehn
lgtm for sky/
6 years ago (2014-12-18 22:25:32 UTC) #4
sky
6 years ago (2014-12-18 22:35:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
92643b500cad7348994999efb91ab26d5be896cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698