Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 814933002: Add an InvariantOutput for the XPF. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add an InvariantOutput for the XPF. The Invariant output holds information about final post blended color and other general information like will it blend with dst. Having this new struct allowed me to also remove some functions that were previously querying subsets of the invariant output. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9e4ecdc9f86724dcce23dc7546e2f295b901407b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -165 lines) Patch
M include/gpu/GrPaint.h View 2 chunks +0 lines, -14 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 2 chunks +13 lines, -9 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M src/gpu/GrPaint.cpp View 2 chunks +14 lines, -25 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +17 lines, -30 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 2 chunks +59 lines, -71 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
egdaniel
6 years ago (2014-12-18 20:07:29 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/814933002/diff/1/src/gpu/effects/GrPorterDuffXferProcessor.cpp File src/gpu/effects/GrPorterDuffXferProcessor.cpp (right): https://codereview.chromium.org/814933002/diff/1/src/gpu/effects/GrPorterDuffXferProcessor.cpp#newcode519 src/gpu/effects/GrPorterDuffXferProcessor.cpp:519: if ((!colorWriteDisabled && colorPOI.readsDst()) || coveragePOI.readsDst()) { output->fWillBlendWithDst ...
6 years ago (2014-12-18 20:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814933002/1
6 years ago (2014-12-18 20:36:09 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-18 20:45:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9e4ecdc9f86724dcce23dc7546e2f295b901407b

Powered by Google App Engine
This is Rietveld 408576698