Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 814853003: CC: Allow per-curve timing functions to be steps timing functions (Closed)

Created:
5 years, 11 months ago by loyso (OOO)
Modified:
5 years, 11 months ago
Reviewers:
dstockwell, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC: Allow per-curve timing functions to be steps timing functions Implement per-curve timing functions. A chromium part. Blink part: https://codereview.chromium.org/800133004 In general: Allow Web Animations with Animation timing functions to run on compositor. BUG=417909 R=dstockwell@chromium.org R=ajuma@chromium.org TEST=ManualTests/animation/compositor-animation-steps.html Committed: https://crrev.com/5dce43319fa35c84218f7d4396a8dd6383046338 Cr-Commit-Position: refs/heads/master@{#310203}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -24 lines) Patch
M cc/blink/web_filter_animation_curve_impl.h View 1 chunk +8 lines, -3 lines 0 comments Download
M cc/blink/web_filter_animation_curve_impl.cc View 1 chunk +17 lines, -5 lines 0 comments Download
M cc/blink/web_float_animation_curve_impl.h View 1 chunk +8 lines, -3 lines 0 comments Download
M cc/blink/web_float_animation_curve_impl.cc View 1 chunk +17 lines, -5 lines 0 comments Download
M cc/blink/web_transform_animation_curve_impl.h View 1 chunk +8 lines, -3 lines 0 comments Download
M cc/blink/web_transform_animation_curve_impl.cc View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
loyso (OOO)
5 years, 11 months ago (2015-01-05 03:58:12 UTC) #1
ajuma
lgtm, but please update the patch title/description to describe what this particular patch does (in ...
5 years, 11 months ago (2015-01-05 15:44:54 UTC) #2
loyso (OOO)
On 2015/01/05 15:44:54, ajuma wrote: > lgtm, but please update the patch title/description to describe ...
5 years, 11 months ago (2015-01-06 00:25:45 UTC) #3
dstockwell
On 2015/01/06 at 00:25:45, loyso wrote: > On 2015/01/05 15:44:54, ajuma wrote: > > lgtm, ...
5 years, 11 months ago (2015-01-06 03:31:08 UTC) #4
dstockwell
On 2015/01/06 at 03:31:08, dstockwell wrote: > On 2015/01/06 at 00:25:45, loyso wrote: > > ...
5 years, 11 months ago (2015-01-06 03:46:07 UTC) #5
loyso (OOO)
On 2015/01/06 03:46:07, dstockwell wrote: > On 2015/01/06 at 03:31:08, dstockwell wrote: > > On ...
5 years, 11 months ago (2015-01-06 03:51:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814853003/20001
5 years, 11 months ago (2015-01-07 00:59:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 01:12:51 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 01:13:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dce43319fa35c84218f7d4396a8dd6383046338
Cr-Commit-Position: refs/heads/master@{#310203}

Powered by Google App Engine
This is Rietveld 408576698