Issue 814833007: bookmarks: Move bookmark_pasteboard_helper_mac functions into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 814833007: bookmarks: Move bookmark_pasteboard_helper_mac functions into 'bookmarks' namespace. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, blundell, sdefresne, sky, nshaik

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

bookmarks: Move bookmark_pasteboard_helper_mac functions into 'bookmarks' namespace. BUG=370433 TEST=unit_tests, components_unittests R=avi@chromium.org Committed: https://crrev.com/6d64e0d964b8b8d8d96146a14cec67312cc48226 Cr-Commit-Position: refs/heads/master@{#309417}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/bookmarks/browser/bookmark_pasteboard_helper_mac.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814833007/1

6 years ago (2014-12-22 12:14:57 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-22 12:55:02 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6d64e0d964b8b8d8d96146a14cec67312cc48226
Cr-Commit-Position: refs/heads/master@{#309417}