Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 814833006: [turbofan] false is also falsish. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] false is also falsish. R=titzer@chromium.org Committed: https://crrev.com/c05d7b059d950b5817acf9f3a7ed10c509d0b32a Cr-Commit-Position: refs/heads/master@{#25904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler/typer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
6 years ago (2014-12-19 13:57:54 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-19 13:58:30 UTC) #2
titzer
lgtm Who would have guessed that false is falsish?
6 years ago (2014-12-19 14:08:22 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as c05d7b059d950b5817acf9f3a7ed10c509d0b32a (presubmit successful).
6 years ago (2014-12-19 14:09:12 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-19 14:09:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c05d7b059d950b5817acf9f3a7ed10c509d0b32a
Cr-Commit-Position: refs/heads/master@{#25904}

Powered by Google App Engine
This is Rietveld 408576698