Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 814763002: Set the document title in the PDF viewer to be the name of the PDF file. (Closed)

Created:
6 years ago by raymes
Modified:
6 years ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the document title in the PDF viewer to be the name of the PDF file. When printing to a PDF from a PDF document, the title of the page gets used. Currently this defaults to the chrome-extension:// URL which is confusing. Instead we use the actual name of the PDF as the title of the extension page which gives the appropriate filename when saving the PDF file from the print menu. BUG=435478 Committed: https://crrev.com/699a2b8e9850048ee5f91f05c452caa32c6cc469 Cr-Commit-Position: refs/heads/master@{#309108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
6 years ago (2014-12-18 05:56:32 UTC) #2
Sam McNally
lgtm
6 years ago (2014-12-18 06:03:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814763002/1
6 years ago (2014-12-18 22:47:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 00:06:06 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-19 00:08:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/699a2b8e9850048ee5f91f05c452caa32c6cc469
Cr-Commit-Position: refs/heads/master@{#309108}

Powered by Google App Engine
This is Rietveld 408576698